Fix function state mutability warning #2358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes state mutability of granularity function from view to pure.
|
I think you meant to tag @frangio? 😅 |
|
Oh I'm sorry for the spam! I meant to tag him but didn't notice that you got tagged |
|
@zemse Oh, this was my bad. I built the release based on the branch |
|
Fixed and released as Thanks for pointing this out, and sorry for the mistake! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @frangio, on upgrading to
3.2.0-solc-0.7release, I noticed that the commit from the PR #2327 wasn't included. But it's there insolc-0.7branch but seems it got missed out in this release branch.I understand that this is a release branch so any more changes are not added to it, but can you merge this PR in the next release branch if it were to be created from this branch instead of
solc-0.7?