Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify ServletUtil to cache wrappers for applicable elements in attributes #346

Closed
jesse-gallagher opened this issue Nov 21, 2022 · 1 comment
Closed

Modify ServletUtil to cache wrappers for applicable elements in attributes #346

jesse-gallagher opened this issue Nov 21, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone
2.13.0

Comments

@jesse-gallagher
Copy link
Member

Since many Servlet classes have attribute storage, it may make sense to store wrapper instances in those attribute maps to avoid having to create new instances for every call.

This is not critical, though, as the wrappers are designed to be stateless other than their wrapped object.
@jesse-gallagher jesse-gallagher added the enhancement New feature or request label Nov 21, 2022
@jesse-gallagher
Copy link
Member Author

A probably-better version is in #433, which wouldn't require even one object per request.

@jesse-gallagher jesse-gallagher mentioned this issue Jun 30, 2023
Open
@jesse-gallagher jesse-gallagher added this to the 2.13.0 milestone Jun 30, 2023
jesse-gallagher added a commit that referenced this issue Jun 30, 2023
@jesse-gallagher
Modify ServletUtil to cache wrappers for applicable elements in attri…
0bb49c5 
…butes (Issue #346)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.13.0
Development

No branches or pull requests
1 participant
@jesse-gallagher