Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix installation within the OpenModelica super project #955

Merged
merged 3 commits into from
Feb 17, 2021

Conversation

lochel
Copy link
Member

@lochel lochel commented Feb 17, 2021

The installation of the simulation server doesn't work on Windows. It works fine on Linux though.

This is an attempt to fix it. The simulation server should only be installed if it is compiled as part of the OpenModelica super project.

@lochel lochel requested a review from adeas31 February 17, 2021 14:39
@lochel
Copy link
Member Author

lochel commented Feb 17, 2021

This doesn't work as expected. It will also install the shared files if compiled "stand-alone". @OpenModelica/omsimulator-developers Does anyone know how we can check in cmake reliably if we are compiling from within the OpenModelica super project or not?

@sjoelund
Copy link
Member

Does anyone know how we can check in cmake reliably if we are compiling from within the OpenModelica super project or not?

Create a cmake variable that is by default false and set it from OpenModelica when calling cmake?

@lochel
Copy link
Member Author

lochel commented Feb 17, 2021

Create a cmake variable that is by default false and set it from OpenModelica when calling cmake?

There must be a better way. I am pretty sure that this information is already somehow available.

@adrpo
Copy link
Member

adrpo commented Feb 17, 2021

Check OMBUILDDIR?

@adeas31
Copy link
Member

adeas31 commented Feb 17, 2021

@lochel can you test if this works in stand-alone case?

@lochel
Copy link
Member Author

lochel commented Feb 17, 2021

@adeas31 it works fine in the stand-alone version 👍

Edit: It also works fine in the OpenModelica super project

@adeas31
Copy link
Member

adeas31 commented Feb 17, 2021

Good. This works from the OpenModelica super project as well and copies the server file.

@lochel lochel enabled auto-merge (squash) February 17, 2021 15:58
@lochel lochel merged commit e26d6e0 into OpenModelica:master Feb 17, 2021
@lochel lochel deleted the win branch February 17, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants