Use f2c translations of LAPACK when no Fortran compiler is available #3539

martin-frbg · 2022-02-23T10:17:47Z

translations done with a modified version of the f2clapack script from PRIMME (which in turn based on the one from f2clapack)
and additional hand-editing to work around use of F90 idiom in current LAPACK.

the current translation drops OpenMP parallelism from the few .F files that used it (f2c limitation, could be put back by hand)
currently omits cgbrfsx,cgerfsx,cherfsx,cporfsx,csyrfsx, zgbrfsx,zgerfsx,zherfsx,zporfsx,zsyrfsx due to TRANSFER intrinsic
~~LAPACK-TEST currently shows failures in ?gelsd~~ only observed with gcc7.5.0
need to update most files to support INTERFACE64 - right now only the absolute minimum needed to run DGESVD (as used to prepare the DGEMM "kernel_regress" test in openblas_utest) is updated as a proof of concept
currently does not work with MSVC (which uses structs to represent complex numbers)
fixes clang64 flang compile failure #3509 and fixes When I compile OpenBLAS with NOFORTRAN=1 some LAPACK (e.g. dpotrf) routines are not available #1284

mmuetzel · 2022-04-04T17:27:44Z

This would already be very useful for the CLANG* build environments in MSYS2 in its current state.
Do you think it could make sense to disable C_LAPACK for MSVC for now (and maybe fix that in a follow up)?

mmuetzel

Just some comments on the existing changes. I hope this is helpful.

mmuetzel · 2022-04-05T08:51:47Z

CMakeLists.txt

-if (NOT NOFORTRAN AND NOT NO_LAPACK)
-  include("${PROJECT_SOURCE_DIR}/cmake/lapack.cmake")
+if (NOT NO_LAPACK)
+    include("${PROJECT_SOURCE_DIR}/cmake/lapack.cmake")


Nit: Should the whitespace change in line 181 be reverted?

mmuetzel · 2022-04-05T08:55:20Z

Makefile

@@ -246,10 +249,10 @@ netlib :

 else
 netlib : lapack_prebuild
-ifeq ($(NOFORTRAN), $(filter 0,$(NOFORTRAN)))
+#ifeq ($(NOFORTRAN), $(filter 0,$(NOFORTRAN)))


Would this condition be better here?

-ifeq ($(NOFORTRAN), $(filter 0,$(NOFORTRAN))) +ifneq ($(NO_LAPACK), 1)

Drop the outer ifneq down there you mean ? Agree this should simplify things a bit.

mmuetzel · 2022-04-05T08:56:21Z

cmake/f_check.cmake

@@ -26,10 +26,15 @@ if(CMAKE_Fortran_COMPILER)
  enable_language(Fortran)
 else()
  if (NOT NO_LAPACK)
-    message(STATUS "No Fortran compiler found, can build only BLAS but not LAPACK")
+	  message(STATUS "No Fortran compiler found, can build only BLAS and f2c-converted LAPACK")


Nit: Whitespace?

now fixed with the temporary exclusion of MSVC

mmuetzel · 2022-04-05T08:57:20Z

cmake/system.cmake

+if (INTERFACE64)
+  set (CCOMMON_OPT "${CCOMMON_OPT} -DLAPACK_ILP64")
+endif ()
+set(TIMER "NONE")


Nit: Intent block by two spaces?

also fixed with the MSVC changes

mmuetzel · 2022-04-09T11:32:32Z

Thanks for the recent changes regarding MSVC and C_LAPACK (or rather their mutual exclusivity for the time being).

I noticed the last couple of changes were related to an issue with clang-cl (MSVC) & flang on Windows. IIUC, that is probably because some tests are run now (after #3595 has landed) that have been skipped previously.
Are those failing tests a blocker for this PR?

martin-frbg · 2022-04-09T12:21:44Z

not a blocker, i just noticed them in the context and wanted to make sure they are unrelated. different pr for that now, will clean up here later when i have time

…penMathLib#3539) * Add C equivalents of the Fortran routines from Reference-LAPACK as fallbacks, and C_LAPACK variable to trigger their use

lesteve · 2023-04-03T08:28:05Z

translations done with a modified version of the f2clapack script from PRIMME (which in turn based on the one from f2clapack)
and additional hand-editing to work around use of F90 idiom in current LAPACK.

@martin-frbg in case you still your modified f2clapack script easy accessible, I would be interested to take a look at it. I am guessing the PRIMME script you started from is https://github.com/primme/primme/blame/master/R/f2clapack.sh?

In a Pyodide context I have been trying to use OpenBLAS (see pyodide/pyodide#3331 for more details). Being able to look at the f2c conversion script (or even run it if possible) you used for OpenBLAS, may help in some cases to reduce the discrepancy we are seeing between some f2c'ed scipy files and OpenBLAS.

martin-frbg · 2023-04-03T08:36:29Z

yes that is what I started from, need to clean up a few hacks that I hand-corrected in the converted files afterwards... mostly fixing some of the fortran function macros from the header part of the primme script that had bad variable types and adding implementations for some complex functions

lesteve · 2023-04-03T09:22:43Z

OK so you changed mostly the header part of the primme script and then modified the result by hand?

I was wondering whether you changed the lex part too, in order to fix some signatures (full disclosure I don't understand what the lex part of the script does).

martin-frbg · 2023-04-17T06:21:45Z

This should be it - sorry for the delay. Obviously some of the changes are OpenBLAS-specific (like the "blasint" typedef) and some of the (complex function) declarations will lead to "unused function" warnings during compilation, so there is certainly still room for improvement
f2clapack.sh.txt

lesteve · 2023-04-17T14:06:44Z

Thanks a lot for the update!

martin-frbg added 30 commits February 22, 2022 19:04

Add C equivalents as fallbacks

1c81f50

Add C versions as fallback

9f0f000

Add C versions as fallback

d1ef539

Add C versions as fallback

5c73f47

Add C versions as fallback

cb6bc65

Add C versions as fallback

8a667a0

Add C versions as fallback

ac44a94

Add C versions as fallback

baab2aa

Add C versions as fallback

3dbefd1

Add C versions as fallback

c23ae2f

Add C versions as fallback

18f3aa1

Add C versions as fallback

538740d

Add C versions as fallback

08fba49

Add C versions as fallback

5d23def

Add C versions as fallback

91118d8

Add C versions as fallback

d604a48

Add C versions as fallback

0e1f896

Add C versions as fallback

cf72d61

Add C versions as fallback

b542c1d

Add C versions as fallback

1ed9c00

Add C versions as fallback

62e3b48

Add C versions as fallback

083bc17

Add C versions as fallback

88ce3f8

Add C versions as fallback

f8e238a

Add C versions as fallback

071f773

Add C versions as fallback

8efa762

Add C versions as fallback

0699e0f

Use C translations of LAPACK when no Fortran compiler is available

3256525

Add C versions as fallback

8a15de0

Include ctype.h for toupper

2a9e337

martin-frbg added 2 commits April 4, 2022 01:08

Update cgbcon.c

ec67809

Update cgbcon.c

740eea9

mmuetzel reviewed Apr 5, 2022

View reviewed changes

martin-frbg added 7 commits April 7, 2022 14:42

Disable fallback to C_LAPACK for MSVC (needs fixes for complex)

ba8995e

Disable C_LAPACK fallback for MSVC

de8ca69

Update system.cmake

2f79f24

Cleanup conditionals around netlib section

f1b4f39

fix typo

7d491ba

Update azure-pipelines.yml

d11985a

Update azure-pipelines.yml

32e83d5

martin-frbg added 2 commits April 9, 2022 19:02

revert unrelated changes

7e010db

Fix indentation

3e98f66

martin-frbg changed the title ~~[WIP] Use f2c translations of LAPACK when no Fortran compiler is available~~ Use f2c translations of LAPACK when no Fortran compiler is available Apr 9, 2022

martin-frbg merged commit b787360 into OpenMathLib:develop Apr 9, 2022

martin-frbg added this to the 0.3.21 milestone Apr 9, 2022

This was referenced Apr 22, 2022

Openblas support on Macosx M1 bytedeco/javacpp-presets#1171

Closed

Fixed LAPACK support for OpenBLAS in Android. bytedeco/javacpp-presets#405

Closed

Error implementing openblas.LAPACKE bytedeco/javacpp-presets#1148

Closed

termoshtt mentioned this pull request Dec 24, 2022

Use tar.gz image of OpenBLAS blas-lapack-rs/openblas-src#95

Merged

juniperfdel mentioned this pull request Jan 26, 2023

new package: libopenblas termux/termux-packages#11441

Merged

martin-frbg mentioned this pull request Jan 26, 2024

Fix LAPACK for f2c converted sources #4453

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use f2c translations of LAPACK when no Fortran compiler is available #3539

Use f2c translations of LAPACK when no Fortran compiler is available #3539

martin-frbg commented Feb 23, 2022 •

edited

Loading

mmuetzel commented Apr 4, 2022

mmuetzel left a comment

mmuetzel Apr 5, 2022

mmuetzel Apr 5, 2022

martin-frbg Apr 7, 2022

mmuetzel Apr 5, 2022

martin-frbg Apr 7, 2022

mmuetzel Apr 5, 2022

martin-frbg Apr 7, 2022

mmuetzel commented Apr 9, 2022

martin-frbg commented Apr 9, 2022

lesteve commented Apr 3, 2023

martin-frbg commented Apr 3, 2023

lesteve commented Apr 3, 2023 •

edited

Loading

martin-frbg commented Apr 17, 2023

lesteve commented Apr 17, 2023

Use f2c translations of LAPACK when no Fortran compiler is available #3539

Use f2c translations of LAPACK when no Fortran compiler is available #3539

Conversation

martin-frbg commented Feb 23, 2022 • edited Loading

mmuetzel commented Apr 4, 2022

mmuetzel left a comment

Choose a reason for hiding this comment

mmuetzel Apr 5, 2022

Choose a reason for hiding this comment

mmuetzel Apr 5, 2022

Choose a reason for hiding this comment

martin-frbg Apr 7, 2022

Choose a reason for hiding this comment

mmuetzel Apr 5, 2022

Choose a reason for hiding this comment

martin-frbg Apr 7, 2022

Choose a reason for hiding this comment

mmuetzel Apr 5, 2022

Choose a reason for hiding this comment

martin-frbg Apr 7, 2022

Choose a reason for hiding this comment

mmuetzel commented Apr 9, 2022

martin-frbg commented Apr 9, 2022

lesteve commented Apr 3, 2023

martin-frbg commented Apr 3, 2023

lesteve commented Apr 3, 2023 • edited Loading

martin-frbg commented Apr 17, 2023

lesteve commented Apr 17, 2023

martin-frbg commented Feb 23, 2022 •

edited

Loading

lesteve commented Apr 3, 2023 •

edited

Loading