Fixed null parameter warning in Mage_Shipping_Model_Resource_Carrier_Tablerate #4073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to reproduce this issue use a table rate in your test environment then follow the checkout steps to the end. Starting with PHP 8.1 to 8.3 you will get this error in the OM log file. ``` Deprecated functionality: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/html/app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate.php on line 131 ``` My approach is using strlen($variable ?? '') but it could be strlen((string) $variabile) too. I am open to opinions.
kiatng
reviewed
Jul 4, 2024
Comment on lines
130
to
131
| $postcode = $request->getDestPostcode(); | ||
| while (strlen($postcode) > 1) { | ||
| while (strlen($postcode ?? '') > 1) { |
There was a problem hiding this comment.
Suggested change
| $postcode = $request->getDestPostcode(); | |
| while (strlen($postcode) > 1) { | |
| while (strlen($postcode ?? '') > 1) { | |
| $postcode = (string)$request->getDestPostcode(); | |
| while (strlen($postcode) > 1) { |
It's more efficient as it's outside the loop.
There was a problem hiding this comment.
good catch @ADDISON74, I like @kiatng version, it looks neater to me because it doesn't get executed inside the loop
fballiano
approved these changes
Jul 4, 2024
fballiano
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to reproduce this issue use a table rate (uploading a CSV file in the Backend) in your test environment then follow the checkout steps to the end.
Starting with PHP 8.1 to 8.3 you will get this error in the OM log file.
My approach is using strlen($variable ?? '') but it could be strlen((string) $variabile) too. Please feel free to share your opinion for the best implementation.