Removed @deprecation on Mage::getBlockSingleton()

[kiatng]

It is referenced in 23 files. The comment stated that it should be replaced by Mage::helper(), but that is a totally different function.

[kiatng]

I have no idea how to fix the PHPStan errors. I never tried to run it locally. But when I tried, I encountered this:

PS D:\Work\Magento\OpenMage\magento-lts> vendor/bin/phpstan analyse --memory-limit 1G --debug
Note: Using configuration file D:\Work\Magento\OpenMage\magento-lts\phpstan.dist.neon.
D:\Work\Magento\OpenMage\magento-lts\api.php
Uncaught Error: Class "Mage_Core_Model_Config_Base" not found in D:\Work\Magento\OpenMage\magento-lts\vendor\macopedia\phpstan-magento1\src\Config\MagentoCore.php:13
#0 phar://D:/Work/Magento/OpenMage/magento-lts/vendor/phpstan/phpstan/phpstan.phar/vendor/composer/ClassLoader.php(576): include()
...
#32 D:\Work\Magento\OpenMage\magento-lts\vendor\phpstan\phpstan\phpstan(8): require('...')
#33 {main}

Not sure how to fix the autoload in phpstan. Any idea?

[fballiano]

@kiatng I don't know windows much but I think using something like ddev makes this kind of things much easier

[kiatng]

I was trying to install DDEV the other day and spent a few hours on it but encountered an error and didn't pursue further. I will try again when I have the time.