Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent saving null log lines to the database #868

Merged
merged 5 commits into from
Jun 15, 2023
Merged

Conversation

elias-ba
Copy link
Contributor

@elias-ba elias-ba commented Jun 11, 2023

Notes for the reviewer

Related issue

Fixes #866

Review checklist

  • I have performed a self-review of my code
  • I have verified that all appropriate authorization policies have been implemented and tested
  • If needed, I have updated the changelog
  • Taylor has QA'd this feature

@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (0bcc598) 92.01% compared to head (563fe07) 92.04%.

❗ Current head 563fe07 differs from pull request most recent head 08856f1. Consider uploading reports for the commit 08856f1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #868      +/-   ##
==========================================
+ Coverage   92.01%   92.04%   +0.02%     
==========================================
  Files         164      164              
  Lines        4271     4274       +3     
==========================================
+ Hits         3930     3934       +4     
+ Misses        341      340       -1     
Impacted Files Coverage Δ
lib/lightning/invocation.ex 97.56% <100.00%> (+0.03%) ⬆️
lib/lightning/invocation/log_line.ex 100.00% <100.00%> (ø)
lib/lightning/pipeline/runner.ex 97.95% <100.00%> (ø)
lib/lightning_web/live/run_live/components.ex 98.61% <100.00%> (+0.69%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@taylordowns2000 taylordowns2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see my one in-line question. otherwise, pending code review from @stuartc and full click testing from @amberrignell , this looks good to go

Copy link
Member

@stuartc stuartc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice.

@taylordowns2000 taylordowns2000 merged commit f9e7fe3 into main Jun 15, 2023
@taylordowns2000 taylordowns2000 deleted the 866-prevent-save branch June 15, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent saving null log lines to the database
3 participants