Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use checkbox on boolean credential fields #1513

Merged
merged 2 commits into from
Dec 3, 2023

Conversation

jyeshe
Copy link
Contributor

@jyeshe jyeshe commented Dec 1, 2023

Notes for the reviewer

Changes the input for boolean credential fields to use a checkbox. This change affects both a new credential as well as the settings credentials editor.

Validation steps

  1. Select or create a workflow
  2. Click on a job and create a new PostgreSQL credential.
  3. Fill all the fields and check "Use SSL"
  4. Save
  5. On main menu, go to Settings->Credentials
  6. Click on edit the credential
  7. See that "Use SSL" is checked and now uncheck it and check the "Allow self-signed certificate"
  8. Save
  9. Click on edit again and find that only "Allow self-signed certificate" is checked

Related issue

Fixes #1430

Review checklist

  • I have performed a self-review of my code
  • I have verified that all appropriate authorization policies have been implemented and tested
  • If needed, I have updated the changelog
  • Product has QA'd this feature

@jyeshe jyeshe self-assigned this Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (2fb3d25) 87.79% compared to head (d602896) 87.68%.

❗ Current head d602896 differs from pull request most recent head 6414bec. Consider uploading reports for the commit 6414bec to get more accurate results

Files Patch % Lines
...live/credential_live/json_schema_body_component.ex 65.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1513      +/-   ##
==========================================
- Coverage   87.79%   87.68%   -0.12%     
==========================================
  Files         216      216              
  Lines        6539     6537       -2     
==========================================
- Hits         5741     5732       -9     
- Misses        798      805       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@taylordowns2000 taylordowns2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works and i'll get it in, but there's another issue here. all values are being written to the DB as strings and sent to the worker as strings too.

@taylordowns2000 taylordowns2000 merged commit ecccb06 into main Dec 3, 2023
0 of 6 checks passed
@taylordowns2000 taylordowns2000 deleted the 1430-checkbox-for-bool branch December 3, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Booleans in postgres credential are appearing as text fields
2 participants