Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show that the jobs' body is invalid #1036

Merged
merged 8 commits into from
Aug 24, 2023
Merged

Conversation

elias-ba
Copy link
Contributor

@elias-ba elias-ba commented Aug 19, 2023

Notes for the reviewer

Related issue

Fixes #957

Review checklist

  • I have performed a self-review of my code
  • I have verified that all appropriate authorization policies have been implemented and tested
  • If needed, I have updated the changelog
  • Product has QA'd this feature

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (1ec7733) 86.18% compared to head (64909d9) 86.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1036      +/-   ##
==========================================
+ Coverage   86.18%   86.22%   +0.04%     
==========================================
  Files         183      183              
  Lines        5210     5226      +16     
==========================================
+ Hits         4490     4506      +16     
  Misses        720      720              
Files Changed Coverage Δ
lib/lightning_web/live/workflow_live/edit.ex 95.55% <100.00%> (+0.34%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@taylordowns2000 taylordowns2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Use icon specified in issue please!
  2. Fix font weight and vertical alignment.

Specification:
image

image

Current proposal:
image

image

@taylordowns2000 taylordowns2000 merged commit 3f04975 into main Aug 24, 2023
8 checks passed
@taylordowns2000 taylordowns2000 deleted the 957-invalid-job-body branch August 24, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show that the jobs' body is invalid
2 participants