-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show that the jobs' body is invalid #957
Comments
stuartc
added
the
needs detail
More detail is needed before development can start
label
Jul 25, 2023
We're looking for two changes here:
Design
|
taylordowns2000
removed
the
needs detail
More detail is needed before development can start
label
Aug 1, 2023
Hey team! Please add your planning poker estimate with Zenhub @elias-ba @stuartc @zacck |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we have no UX/UI hints that a Job's body is invalid.
At the moment, the only invalid state that exists is when the body for the code editor is empty.
In future, we will have another story expanding this for other error states.
Technical Notes
Unlike #956 this button exists in LiveView.
Lets not change the Ecto model validation messages: i.e. "body can't be blank".
But rather use the
.errors
struct and it's metadata to determine if the validation failure forbody
is from avalidate_required
etc.The text was updated successfully, but these errors were encountered: