Save Axolotl config as WandB artifact #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NanoCode012
reviewed
Oct 11, 2023
| artifact = wandb.Artifact(name="axolotl-config", type="config") | ||
| artifact.add_file(local_path=self.cfg.axolotl_config_path) | ||
| wandb.run.log_artifact(artifact) | ||
| LOG.info("Axolotl config has been saved to WandB as an artifact.") |
There was a problem hiding this comment.
maybe log.debug is enough
There was a problem hiding this comment.
Im indifferent, we log/print 20+ lines of Wandb initialization (and hundreds of lines on training begin) anyway, wouldn't it make sense to leave it at info to make people aware that their config is archived - how should anyone (except us) ever find/know it otherwise?
With an explicit (short) statement after successful archivation in the log, people then know that they can e.g safely overwrite their config.yml for a new experiment.
But happy to change that as well, whats your opinion @winglian ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on discord, tested it and works fine for me (but happy for suggestions/improvements, im not a WandB expert).