[Spec] Add default http scheme for server URL, Fix #181 #498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.1.x
,4.0.x
. Default:master
.Description of the PR
fix #181
sanitizeUrl
.[0-9a-z.+\-]
. Can be made more generic to match[^\p{Space}:/]
bin/go-petstore.sh
after removing thescheme
from the spec and it works as expected. Didn't check in the changes because it requires a change in the spec.Current Behavior before PR for
bin/go-petstore.sh
Removing the scheme from the spec results in the following warning and a non-working client.
Generated
configuration.go
causesmvn integration-test
to fail:New Behavior
bin/go-petstore.sh
configuration.go
withhttp
scheme and passing integration tests.