Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java][okhttp-gson] Keep AST small when using builder #12610

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Jun 15, 2022

Currently when we use gson builder all calls are connected with dot.
This results in pretty long instruction that is problematic to parse for AST tools (e.g. lombok).
To fix this we can slice this giant call into series of direct calls on named builder.
As a result we get multiple short and easy to parse instructions instead of one long.

Fixes:

Refs:

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.0.1) (patch release), 6.1.x (breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc: @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608

@janisz janisz requested a review from jimschubert as a code owner June 15, 2022 21:32
@janisz janisz changed the base branch from 6.0.x to master June 15, 2022 21:33
@janisz janisz changed the title Keep AST small when using builder [java][okhttp-gson] Keep AST small when using builder Jun 15, 2022
@wing328 wing328 added this to the 6.0.1 milestone Jun 17, 2022
@wing328
Copy link
Member

wing328 commented Jun 17, 2022

LGTM. Thanks for the enhancemenet.

@wing328 wing328 merged commit 0140f84 into OpenAPITools:master Jun 17, 2022
@janisz
Copy link
Contributor Author

janisz commented Jun 17, 2022

@wing328 should I create backport PRs?

@wing328
Copy link
Member

wing328 commented Jun 17, 2022

No. The upcoming release is 6.0.1 and there will be no more 5.x release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants