-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dart] json_serializable: remove experimental generator #10532
[dart] json_serializable: remove experimental generator #10532
Conversation
is this replaceable by dart-dio-next? |
No, this is a breaking change, it's up to users to decide which other generator to use. dart-dio-next support null-safety, this one doesn't and won't. |
are there extra features that this supports better than dart-dio-next? or is it just different libraries? if it's just different libraries, then I think it is ok to remove, since dart-dio-next is built to be library agnostic. if it has better features, then we can migrate them to dart-dio-next first before it's removed. |
It's a different serialization library that generates code using compile time. I added it as I was big user of json_serializable, but since they (j_s) IMO made quite poor design choices while upgrading package to dart 2.12 I stopped using that library, no one else contributed to this generator and no bug was raised, which simply means it's not used. |
…to dart-remove-json_serializable
Updated branch just to trigger failing test (failed to download mvn dependencies) |
I am fine with this, we can always add it back again later after the NNBD migration. |
Can we get this in @wing328 pls? Failure is unrelated |
…to dart-remove-json_serializable
…to dart-remove-json_serializable
Thanks :) |
I added this generator to help out with future migrations, but it doesn't look like anyone is using it, contributing to it or even reporting bugs. It adds extra maintenance burden to dart generators, so it can go away.
It was always marked as experimental.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x