Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Linux kconfig for openamp #48

Merged
merged 9 commits into from
Jul 11, 2024
Merged

Conversation

wmamills
Copy link
Collaborator

@wmamills wmamills commented Jul 5, 2024

Linux Kconfig fix-up and clean-up

  • Move UIO out of all machines default and make it work
  • Enable the name service by default
  • Fix AMD Xilinx R5 driver config name
  • Include the RPMSG sample by default for our MACHINES
  • Remove config items that should be done at the BSP level
  • Eliminate warnings
  • Cleanup and comments

UIO is a controversial feature.  We should not enable it in the openamp.cfg
which is used by every kernel and every machine (when openamp is in
DISTRO_FEATURES).

Instead move it to remoteproc-*.cfg as that is only included by
specific machines (and also only when enabled via openamp DISTRO_FEATURE).

The old config was not doing any good anyway as the base level UIO
was not enabled.  We fix this here also.

Signed-off-by: Bill Mills <bill.mills@linaro.org>
The name service is a default part of rpmsg and should be enabled by
default.

Signed-off-by: Bill Mills <bill.mills@linaro.org>
Actually say what this file is for.

Signed-off-by: Bill Mills <bill.mills@linaro.org>
The CONFIG_ name was changed on its way upstream.  Use the name that
made it upstream.

Signed-off-by: Bill Mills <bill.mills@linaro.org>
Adding configs in both places just adds confusion.
Only add things not already in openamp.cfg

Signed-off-by: Bill Mills <bill.mills@linaro.org>
Since we are getting rid of BSP level files, move this define to the file
we are keeping as it is part of the remoteproc enablement for
Qualcomm platforms.

Signed-off-by: Bill Mills <bill.mills@linaro.org>
These were added when we were using qemu targets as stand-ins for generic*
targets.  Now that we have genericarm64 and we also have meta-openamp-bsp
for testing, we don't need these.

Any BSP level configs should be at the BSP layer not in meta-openamp.

Signed-off-by: Bill Mills <bill.mills@linaro.org>
When using genericarm64 with linux-yocto we get warnings when this is set
to =m so switch to =y

Signed-off-by: Bill Mills <bill.mills@linaro.org>
Enable the rpmsg sample for all machines that opt into the remoteproc
mix-in.

Signed-off-by: Bill Mills <bill.mills@linaro.org>
@wmamills
Copy link
Collaborator Author

wmamills commented Jul 5, 2024

I am happy to pull specific commits out of this PR and in to another PR if their is a good reason to delay them.

This PR is not strictly required for the OpenAMP 2024.05 release as I can do workarounds in the test BSP layer. However I would like to include all of these commits unless there is a compelling reason not to.

@mhatle
Copy link
Collaborator

mhatle commented Jul 9, 2024

No concerns.

@wmamills wmamills merged commit bd29711 into OpenAMP:master Jul 11, 2024
@wmamills wmamills deleted the fixup-kconfig branch August 11, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants