Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename_labels: confusion between target and source #321

Closed
Ardweaden opened this issue Feb 14, 2022 · 2 comments
Closed

rename_labels: confusion between target and source #321

Ardweaden opened this issue Feb 14, 2022 · 2 comments
Assignees

Comments

@Ardweaden
Copy link
Contributor

Process ID: rename_labels

Describe the issue:

The definition states:

If the dimension labels are not enumerated and the target parameter is not specified, the LabelsNotEnumerated exception is thrown.

Similarly later, by the information about the target parameter:

The dimension labels in the data cube are expected to be enumerated if the parameter target is not specified.

I fail to understand this. Firstly, target is a required parameter. Secondly, one would expect that source is necessary if the labels are not enumerated and if not, the error would make sense.

Proposed solution:

Perhaps source was meant in both cases.

@m-mohr
Copy link
Member

m-mohr commented Feb 14, 2022

Thanks for bringing this up. Indeed, source was meant in both cases.

m-mohr added a commit that referenced this issue Feb 14, 2022
…s thrown if `source` is empty instead of if `target` is empty. #321
@m-mohr
Copy link
Member

m-mohr commented Feb 14, 2022

Fixed in f12ffb2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants