Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apple started rejecting OneSignal SDK because of UIWebView API #522

Closed
arthurdapaz opened this issue Sep 2, 2019 · 5 comments · Fixed by #524
Closed

Apple started rejecting OneSignal SDK because of UIWebView API #522

arthurdapaz opened this issue Sep 2, 2019 · 5 comments · Fixed by #524

Comments

@arthurdapaz
Copy link

arthurdapaz commented Sep 2, 2019 •
edited
Loading

Description:
Apple will start rejecting apps that directly or indirectly calls for UIWebView API. (OneSignal framework, GoogleSignIn SDK, for example are both being warned by Apple automatic review process)

UIWebView is deprecated since iOS 12*. So, for best practice we should replace it for WKWebView

Environment
Swift 5 (target: iOS 10.0), latest OneSignal framework

Steps to Reproduce Issue:

  1. Send new app for TestFlight that uses OneSignal iOS SDK
  2. Wait for automatic app review
  3. Wait for the reproval/rejection automatic message by Apple

Anything else:
Didn't find any branch dealing with this issue. Suggestion is to use WKWebView which is modern and encouraged by Apple
@arthurdapaz arthurdapaz changed the title Apple is rejecting OneSignal SDK because the presence of UIWebView Apple is rejecting OneSignal SDK because UIWebView Sep 2, 2019
@inkly
Copy link

inkly commented Sep 3, 2019 •
edited
Loading

Same here

ITMS-90809: Deprecated API Usage - Apple will stop accepting submissions of apps that use UIWebView APIs . See https://developer.apple.com/documentation/uikit/uiwebview for more information

@jkasten2 jkasten2 mentioned this issue Sep 3, 2019
Merged
@jkasten2
Copy link
Member

jkasten2 commented Sep 3, 2019

@arthurdapaz @inkly Thanks for reporting, a fix has been merge in and will be included in the next release

@arthurdapaz arthurdapaz changed the title Apple is rejecting OneSignal SDK because UIWebView Apple started rejecting OneSignal SDK because of UIWebView API Sep 4, 2019
@ianmcgregor ianmcgregor mentioned this issue Sep 4, 2019
Closed
This was referenced Sep 6, 2019
Closed
Closed
@Nodonisko Nodonisko mentioned this issue Sep 11, 2019
Closed
@Aarbel
Copy link

Aarbel commented Sep 11, 2019 •
edited
Loading

@jkasten2 do you have any infos when the next release will be available ?

@dan-ms dan-ms mentioned this issue Oct 1, 2019
Closed
chmiiller added a commit to chmiiller/com.williamrijksen.onesignal that referenced this issue Feb 21, 2020
@chmiiller
Updates iOS One Signal SDK to 2.12.6. This is a major update since it:
44cf265 
- Removes deprecated UIWebView usage from original SDK (OneSignal/OneSignal-iOS-SDK#522)
- Fixes a problem while building it with Xcode 11 (williamrijksen#85)
- Removes deprecated API call to IdsAvailable
- Adds CoreGraphics and WebKit must haves frameworks
- Updates to Titanium 8.x SDK
- Uses TitaniumKit framework and sets CLANG_ENABLE_MODULES to true on project configuration
@chmiiller chmiiller mentioned this issue Feb 21, 2020
Merged
@prabhashibuddhima
Copy link

Hi,

I'm facing the same problem. How can I fix it?

@jkasten2
Copy link
Member

jkasten2 commented Dec 7, 2020

This fix was included in OneSignal-iOS-SDK 2.10.2 released Sep. 3 2019.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added WebKit to podspec dependencies OneSignal/OneSignal-iOS-SDK
5 participants
@jkasten2 @arthurdapaz @inkly @Aarbel @prabhashibuddhima