Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include System.ValueTuple in C# Scripts #722

Merged
merged 3 commits into from
Jan 11, 2017

Conversation

filipw
Copy link
Member

@filipw filipw commented Jan 10, 2017

This PR adds System.ValueTuple automatically into the compilation references.

This is required because it's already part of "standard scripting" - CSI also automatically adds it dotnet/roslyn@4d6c590, allowing users to use tuples straight away without any extra manual set up.

Before the change

screenshot 2017-01-10 08 43 43

After the change

screenshot 2017-01-10 08 40 09

@filipw
Copy link
Member Author

filipw commented Jan 11, 2017

small step for OmniSharp, large step for CSX script authors :)

Copy link
Member

@david-driscoll david-driscoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno... looks like a lot of changes to me!

LGTM

@david-driscoll david-driscoll merged commit d3eec44 into OmniSharp:dev Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants