-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: align obs_names
of mod2 to mod1 when necessary
#380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the test epochs are too small, the cost matrix is infeasible will occur in minimum_weight_full_matching
Obs_names of mod2 that are numbers can be aligned to obs_names of mod1
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
RemyLau
requested changes
Dec 11, 2023
Revisit the GSE117089 data set, updated the batch labels, and have been tested
GSE117089 dataset,it is the same as match_modality
for more information, see https://pre-commit.ci
RemyLau
approved these changes
Dec 18, 2023
obs_names
of mod2 to mod1 when necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the test epochs of match modality-scmognn-gex2adt_subset to prevent minimum_weight_full_matching from reporting an error cost matrix is infeasible. In addition, the obs_names of mod2 that are numbers in match_modality are aligned with the obs_names of mod1. However, it should be noted that these are all in Modified locally, I will test it again when my vscode can be directly connected to github.
I have tested it in new server.
Update datasets with appropriate batch labels.
Currently I am still copying and pasting updates, I will try to connect directly soon.