Skip to content

Commit

Permalink
Mark classes of package uimanager as @nullsafe (facebook#43156)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebook#43156

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Reviewed By: javache

Differential Revision: D54027185

fbshipit-source-id: f3c337def2d42cf1f6fed2e2eb4938a84a51f8d4
  • Loading branch information
mdvacca authored and facebook-github-bot committed Feb 23, 2024
1 parent ed3eacb commit c77c13a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,15 @@
package com.facebook.react.uimanager;

import android.view.Choreographer;
import com.facebook.infer.annotation.Nullsafe;
import com.facebook.react.bridge.JSExceptionHandler;
import com.facebook.react.bridge.ReactContext;

/**
* Abstract base for a Choreographer FrameCallback that should have any RuntimeExceptions it throws
* handled by the {@link JSExceptionHandler} registered if the app is in dev mode.
*/
@Nullsafe(Nullsafe.Mode.LOCAL)
public abstract class GuardedFrameCallback implements Choreographer.FrameCallback {

private final ReactContext mReactContext;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,11 @@

import android.view.View;
import androidx.annotation.Nullable;
import com.facebook.infer.annotation.Nullsafe;
import com.facebook.react.bridge.JSApplicationCausedNativeException;

/** An exception caused by JS requesting the UI manager to perform an illegal view operation. */
@Nullsafe(Nullsafe.Mode.LOCAL)
public class IllegalViewOperationException extends JSApplicationCausedNativeException {

@Nullable private View mView;
Expand Down

0 comments on commit c77c13a

Please sign in to comment.