Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ConfigParser compatibilty #120

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Fix ConfigParser compatibilty #120

merged 2 commits into from
Nov 22, 2023

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented May 10, 2022

This v1.1 template stands in .github/.

This PR

Add character x [x].

  • I've read the DCO. - no, my browser says the site is not safe
  • I've read the Coding Guidelines - no, as above
  • The relevant informations about the changes stands in the commit message, not here in the message of the pull request.
  • Code changes follow the style of the files they change.
  • Code is tested (provide details).

References

python/cpython#92503

Additional information

@hugovk
Fix ConfigParser compatibilty
74c1812 
The SafeConfigParser class has been renamed to ConfigParser
in Python 3.2. This alias will be removed in Python 3.12.
Use ConfigParser directly instead.

https://github.com/python/cpython/blob/75280944e5ca957eec7f814b9d0608fc84fc5811/Lib/configparser.py#L1242-L1252
@hugovk hugovk mentioned this pull request May 10, 2022
Merged
@hugovk
Copy link
Contributor Author

hugovk commented May 3, 2023

The old SafeConfigParser has been removed in Python 3.12, which will be in beta in a week or two, and set for full release in October.

configparser no longer has a SafeConfigParser class. Use the shorter ConfigParser name instead.

https://docs.python.org/3.12/whatsnew/3.12.html#removed

@hugovk
Copy link
Contributor Author

hugovk commented May 13, 2023

Closing this year-old PR, but happy to re-open if you'd like OfflineIMAP to work on Python 3.12 (in beta next week).

@hugovk hugovk closed this May 13, 2023
@chris001
Copy link
Member

Yes... compatibility with 3.12 would be a very good thing!

@hugovk hugovk reopened this May 13, 2023
@hugovk
Copy link
Contributor Author

hugovk commented May 13, 2023

Re-opened!

@chris001
Update CustomConfig.py
1455770 
Call the right base class, `ConfigParser` (not `SafeConfigParser`)
@chris001 chris001 requested review from thekix and nicolas33 May 25, 2023 21:37
@chris001 chris001 added the bug Something isn't working label May 26, 2023
@serge-sans-paille
Copy link
Contributor

+1 for merging this in. I've backported the patch to fedora f38

@hugovk hugovk closed this Nov 5, 2023
@thekix thekix reopened this Nov 22, 2023
@thekix
Copy link
Member

thekix commented Nov 22, 2023

Hi,

Sorry about the delay. I think the patches are ok. Should I merge it?

Best regards,
kix

thekix
thekix approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@thekix thekix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #164

@hugovk
Copy link
Contributor Author

hugovk commented Nov 22, 2023 •
edited
Loading

Yes, this should be merged to support 3.12.

@thekix thekix merged commit a195155 into OfflineIMAP:master Nov 22, 2023
@hugovk hugovk deleted the fix-configparser branch November 22, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekix thekix thekix approved these changes

@nicolas33 nicolas33 Awaiting requested review from nicolas33

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hugovk @chris001 @serge-sans-paille @thekix