Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that Weth gateways are registered in the deployment test #72

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

gvladika
Copy link
Contributor

Update deployment test (used for both CI and prod) to check that L1 and L2 weth gateways are registered in respective routers.

Copy link
Member

@gzeoneth gzeoneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the weth gateway registration check should be separate, or at least after everything else is checked, so you can check for token bridge deployment before registering weth gateway before registering

@gvladika
Copy link
Contributor Author

gvladika commented Feb 2, 2024

the weth gateway registration check should be separate, or at least after everything else is checked, so you can check for token bridge deployment before registering weth gateway before registering

Let's put it as the last check with proper message. I'm concerned that if we put it in separate test, then it might get overlooked and never executed at all.

Base automatically changed from reg-weth-gw to main February 5, 2024 15:34
Copy link
Member

@gzeoneth gzeoneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gzeoneth gzeoneth merged commit d6f2e03 into main Mar 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants