add doc for spack install with external modules #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streeve
reviewed
Jul 1, 2024
|
I addressed the above comments. It's a good point that this could be more general. One of the other use cases that I didn't think of originally is that if there is a system module for OpenFOAM-10, then you can create a spack package specification to wrap it and still use the spack installation of additivefoam. I'd guess it will be less straightforward to use a standalone install of OpenFOAM-10 with spack, becuase of the environmental setup that would need to be run when loading the spack module. But I don't know enough about spack to write an example of that right now. |
streeve
approved these changes
Jul 2, 2024
|
@colemanjs good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added documentation for installing the
additivefoamspack module when you are using modules external to spack. This is useful when you need to install OpenFOAM on the system in addition to the AdditiveFOAM solver and you have system modules available to you for common libraries like C++ and MPI.