Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback F13 (issue 6, TM): Section V.0.4: It is not clear why there are three empty rows. #355

Closed
valexande opened this issue May 2, 2023 · 4 comments
Assignees
Labels
type: bug Something implemented incorrectly in a release.
Milestone

Comments

@valexande
Copy link
Collaborator

Section V.0.4: It is not clear why there are three empty rows.
The fact that the contest is terminated without an award can be made by indicated epo:ProcurmentProcessInformation epo:isCompetitionTerminated in conjunction epo:hasAwardStatus …clos-nw which is in the rdf but not in the mapping

@csnyulas
Copy link
Contributor

csnyulas commented May 3, 2023

The reason for these three empty rows comes from the three rows providing mappings on epo:Contract and epo:LotAwardOutcome based on a similar question ("A concession/lot is awarded?") in F23 and F25.
However, we did not know what would be the appropriate mapping in case of F13, where the question is "The contest was terminated without an award or attribution of prizes?" and the XPaths are RESULTS/AWARDED_PRIZE/RESULTS/NO_AWARDED_PRIZE. That's the reason for leaving the cells highlighted in yellow.

image

@valexande
Copy link
Collaborator Author

@csnyulas Maybe what Natalie is suggesting here for the second part " epo:ProcurmentProcessInformation epo:isCompetitionTerminated in conjunction epo:hasAwardStatus", is that maybe we should consider representing this information through epo:ProcurementProcessInformation.

As the property epo:isCompetitionTerminated has the description: "No further contracts will be awarded in this procedure. Additional Information: This can be instantiated in the post award phase. PIN for Competition needs to be signaled. This field can be used even if no contracts are awarded in the contract award notice. This corresponds in eForms to BT-756 PIN Competition Termination."

Moreover, epo:ProcurementProcessInformation is connected with an epo:Lot through epo:concernsLot, and as I can understand epo:Contract is connected with an epo:Lot with epo:includesLot.

@csnyulas csnyulas added the type: implementation question something needs clarified, refined or decided before the implementation can continue label May 3, 2023
@csnyulas
Copy link
Contributor

csnyulas commented Jun 1, 2023

Clarification from @muricna : Use two mappings to express the fact that the competition is terminated (Xpath: RESULTS/NO_AWARDED_PRIZE):
image

and

image

and one mapping when the competition was NOT terminated (Xpath: RESULTS/AWARDED_PRIZE):

image

@csnyulas csnyulas added the act: for implementation all is clear, it can be implemented and closed label Jun 1, 2023
csnyulas added a commit that referenced this issue Jun 9, 2023
@csnyulas
Copy link
Contributor

csnyulas commented Jun 9, 2023

CM (v 2.1.1-beta.2) was also updated to reflect the changes:
image

@csnyulas csnyulas closed this as completed Jun 9, 2023
@csnyulas csnyulas added type: bug Something implemented incorrectly in a release. and removed type: implementation question something needs clarified, refined or decided before the implementation can continue act: for implementation all is clear, it can be implemented and closed labels Jun 9, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something implemented incorrectly in a release.
Projects
None yet
Development

No branches or pull requests

4 participants