Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERCENTAGE Questions: Artifact Examples and Shematrons Inconsistency #interproc #390

Closed
konstantinosraptis91 opened this issue Jun 15, 2023 · 4 comments

Comments

@konstantinosraptis91
Copy link

konstantinosraptis91 commented Jun 15, 2023

Hi ESPD team,

I think I detected an inconsistency in the example artifacts and also in the Schematron rules. Specifically, QUESTIONs of PERCENTAGE valueDataTypeCode are expected to have a "cac:TenderingCriterionResponse / cac:ResponseValue / cbc:ResponseQuanity" instead of a "cac:TenderingCriterionResponse / cac:ResponseValue / cbc:ResponseNumeric". In the technical handbook, there is a reference in Table 94 that claims that QUESTIONs of PERCENTAGE ValueDataTypeCode are being mapped to a "/cac:TenderingCriterionResponse /cac:ResponseValue / cbc:ResponseNumeric" as you can see in the snippet below.

image

Additionally, the relevant example table (Table 43) shows that cbc:ResponseNumeric is the element that has to be used for PERCENTAGE QUESTIONs mapping:

image

Kind regards,
Konstantinos

@konstantinosraptis91 konstantinosraptis91 changed the title PERCENTAGE Questions Examples and Shematrons Inconsistency #interproc PERCENTAGE Questions: Artifact Examples and Shematrons Inconsistency #interproc Jun 15, 2023
@pascalinelaur
Copy link
Contributor

pascalinelaur commented Jun 21, 2023

Hello @konstantinosraptis91 ,

Thank you very much for your question.

After analysis:

In the Online documentation, the table 94 states that for the datatype "Percentatge" we should have a "cac:ResponseValue/cbc:ResponseNumeric". ​

Also, in the UBL documentation, a "ResponseNumeric" is used for a number, rate or percent as a reply to the criterion requirement. ​

Therefore, for "Percentage" datatype, we should change "ResponseQuantity" to "ResponseNumeric" ​in the related XSLT files.

We didn't encounter any validation error related to this datatype "Percentage", so we should also add a validation rule for the "Percentage" case, so that the constraint is properly validated.

​This change will be done in the next release.

Kind regards,
The ESPD Team.

@konstantinosraptis91
Copy link
Author

Hi @pascalinelaur

We encountered a validation error by using the ITB validator that suggests we must use a ResponseQuantity instead of a ResponseNumeric for a PERCENTAGE response. By reading your answer, it's not very clear that you will also update the improper current Schematron rule. I don't know if updating the related XSLTs will also update/impact the inconsistent current Schematron rule.

Kind regards,
Konstantinos

@pascalinelaur
Copy link
Contributor

pascalinelaur commented Jun 26, 2023

Hello @konstantinosraptis91,

Thank you for your follow up question.

We will check the schematron rules.

There are 2 cases: either a rule exist and is using incorrect values in which case we will correct it, or the rule doesn't exist and we will have to add one.

Kind regards,
The ESPD Team

pascalinelaur added a commit that referenced this issue Jul 19, 2023
…listVersionID

Fix TEDSPD-583 Validation, TEDSPD-572 #390 Percentage, TEDSPD-569 #387 listVersionID
@pascalinelaur
Copy link
Contributor

Since we don't have any further comments, we proceed to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants