Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regarding the correct listID values #interproc #380

Closed
konstantinosraptis91 opened this issue Feb 20, 2023 · 9 comments
Closed

Comments

@konstantinosraptis91
Copy link

Hello ESPD team,

It seems that some of the examples (snippets) that are included in the technical handbook have different listID attribute values for certain elements compared to the respective Schematron rules. For instance, according to the technical handbook, the correct @listID value for cbc:PropertyGroupType is "property-group-type"

Στιγμιότυπο οθόνης 2023-02-20, 4 46 25 μμ

Στιγμιότυπο οθόνης 2023-02-20, 4 46 56 μμ

But the relevant Schematron rule demands the @listID value for this element to be equal to "PropertyGroupType". Can you clarify please what are the correct listID values for those elements?

@konstantinosraptis91
Copy link
Author

Following the discussion we had in today's OUC (OUC 23-02-2023) considering this issue, I would like to ask because I am unsure if I got it right if this issue will be addressed within the v3.2.0 or later with the v4.0.0 release.

@delgajc
Copy link
Contributor

delgajc commented Feb 23, 2023

Good afternoon,

this issue will be addressed with the v4.0.0 release since the scope for v3.2.0 was already closed some weeks ago and this release is about to be published shortly (pending to fix some technical issues).

We are analyzing these inconsistencies in the codelist elements and will provide more information here after the conclusion of the analysis.

Kind Regards,
The ESPD Team.

@konstantinosraptis91
Copy link
Author

Hello @delgajc

Thank you for your answer. Can you please provide us with a list containing the exact listID values per codelist expected in version 3.1.0 and 3.2.0 to avoid further misconceptions? It would also be nice if you could update the technical handbook because, as it is right now, it is not clear what are the correct values.

@delgajc
Copy link
Contributor

delgajc commented Mar 7, 2023

Dear Konstantinos,

please find below a table with the right listID values per codelist expected in version 3.1.0 and 3.2.0. We will fix the errors in the technical handbook and in the schematron files for 3.2.0, but bear in mind that currently the codelists maintained by ESPD Team are not validating the listID (this attribute is not included in the genericode files). This validation will be included in a future release.

<style> </style>
ShortName ListID Maintainer
AccessRight access-right EU Vocabularies
BooleanGUIControlType boolean-gui-control-type ESPD Team
Country country EU Vocabularies
Criterion criterion EU Vocabularies
CriterionElementType criterion-element-type ESPD Team
Currency currency EU Vocabularies
DocRefContentType docrefcontent-type EU Vocabularies
EconomicOperatorSize economic-operator-size EU Vocabularies
EOIDType eoid-type ESPD Team
EoRoleType eo-role-type EU Vocabularies
FinancialRatioType financial-ratio-type ESPD Team
Language language EU Vocabularies
Occupation occupation ESPD Team
ProfileExecutionID profile-execution-id ESPD Team
PropertyGroupType property-group-type ESPD Team
ResponseDataType response-data-type ESPD Team

Kind Regards,
The ESPD Team.

@konstantinosraptis91
Copy link
Author

Thank you! @delgajc

@Nikanoras
Copy link

What about ProcedureType?

@delgajc
Copy link
Contributor

delgajc commented Mar 22, 2023

Dear @konstantinosraptis91

there were some mistakes in the table I previously sent. Please find below the correct listID values for all the codelists:

We are working to fix all the discrepancies in the documentation and ESPD artifacts to be included in next release 3.2.0.

Dear @Nikanoras, ProcedureType is an obsolete codelist no longer maintained in ESPD in versions 3.x.x.

Kind regards,
The ESPD Team.

<style> </style>
ShortName ListID Maintainer
AccessRight http://publications.europa.eu/resource/authority/access-right EU Vocabularies
BooleanGUIControlType boolean-gui-control-type ESPD Team
Country http://publications.europa.eu/resource/authority/country EU Vocabularies
Criterion http://publications.europa.eu/resource/authority/criterion EU Vocabularies
CriterionElementType criterion-element-type ESPD Team
Currency http://publications.europa.eu/resource/authority/currency EU Vocabularies
DocRefContentType http://publications.europa.eu/resource/authority/docrefcontent-type EU Vocabularies
EconomicOperatorSize http://publications.europa.eu/resource/authority/economic-operator-size EU Vocabularies
EOIDType eoid-type ESPD Team
EoRoleType http://publications.europa.eu/resource/authority/eo-role-type EU Vocabularies
FinancialRatioType financial-ratio-type ESPD Team
Language http://publications.europa.eu/resource/authority/language EU Vocabularies
Occupation http://publications.europa.eu/resource/authority/occupation EU Vocabularies
ProfileExecutionID profile-execution-id ESPD Team
PropertyGroupType property-group-type ESPD Team
ResponseDataType response-data-type ESPD Team

pascalinelaur added a commit that referenced this issue Apr 14, 2023
Fix ESPD v3.2.0 with #380 Validation for GitHub ESPD-EDM
@pascalinelaur
Copy link
Contributor

Hello @Nikanoras ,

Related the codelist "ProcedureType", the proper name is actually "ProcurementProcedureType" from the EU Vocabularies.
However, this codelist is not maintain in the ESPD project because the data can be retrieved from the eForms and hence there is no use-context for the ESPD .

For the next release, you will find the element "ProcedureCode" with the attribute "listID" assigned to a Dummy value. You can already check this in the master branch, folder xml-examples.

Kind regards,
The ESPD Team.

@pascalinelaur
Copy link
Contributor

Hello,

The ESPD version 3.2.0 has been released with a broader solution for this github issue. We reviewed all the codelists listID values in XSL file, generic code files, XSLT files, XML files and Schematron files as well. We also updated the listID values in the online documentation.

With all that being said, this issue is resolved and closed.

Kind regards,
The ESPD Team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants