Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General yearly turnover - differences in taxonomy and mock-ups from ESPD-EDM #340

Closed
JustinaZaltauskaite opened this issue Aug 12, 2022 · 10 comments

Comments

@JustinaZaltauskaite
Copy link

Hi,
We started digging into criterias a bit deeper and saw that "General yearly turnover" has few differences in mock-ups and taxonomy

  1. mockups have fields for Fiscal year count and threshold per year, but taxonomy does not have whose fields
    image

  2. evidence question "Is this information available electronically?" is doubled
    image

  3. Question "In case the information concerning turnover (general or specific) is not available for the entire period required, please state the date on which the economic operator was set up or started trading:" does not exist in a mock-up
    image

Feels like something is missing or there is too much in this criteria to properly understand how this criteria works. In our implementation we generate ESPD document directly from taxonomy and this criteria currently looks a bit off, although other criteria (that we implemented) look ok

@hricolor
Copy link
Collaborator

Good morning,
Thank you very much for your comment.
Regarding your three bullets, we would like to comment on the following:

  • Regarding the first bullet: it is accurate that the data structure for the criterion does not include the information that the mock-up shows. Therefore, the data structure needs to be updated accordingly.

    • Within the requirement group a requirement needs to be added to show the number of fiscal years to be covered.
    • The data structure for the second question subgroup has cardinality 1 which needs to be changed to 1..n.
      Issue340
  • Concerning the second bullet: This question is duplicated because the first time is related to the EO meeting directly the requirements established by the Buyer. And the second question is associated with the set-up of the EO (in cases where the EO was set up at a date not allowing it to fulfil the requirement).

  • And the last bullet: The documentation needs to be updated to reflect the question that currently is not depicted.

First bullets will be implemented in the following GitHub branch https://github.com/OP-TED/ESPD-EDM/tree/criterion-evolution.

We will inform you when the changes are applied.

delgajc added a commit that referenced this issue Aug 24, 2022
@acolomer
Copy link
Contributor

acolomer commented Sep 13, 2022

Good morning,
The fix has been implemented in the following GitHub branch: https://github.com/OP-TED/ESPD-EDM/tree/criterion-evolution.

The criterion excel in the aforementioned link has been updated and the corresponding XML sample file has been generated.
This will be included in a future ESPD-EDM release.
We therefore close the ticket.
Kind regards,
The ESPD-EDM Team

@JustinaZaltauskaite
Copy link
Author

@acolomer when does this future ESPD-EDM release happen?

@acolomer
Copy link
Contributor

Good morning,
The scope and calendar for future ESPD-EDM releases will be discussed in the next OUC meeting, scheduled for September 28th.
Kind regards,
The ESPD-EDM Team

@JelenaCaik
Copy link

Hello @acolomer, @hricolor, @delgajc,
Thank you very much for your answers.
It is still not clear for us how to handle checkbox "Threshold per year" shown in a mockup and missing in Taxonomy excel file.
There is no requirement for "Threshold per year" in Taxonomy file.
How do we need to handle it?

  • Do we need to show N times Amount and currency when checkbox "Threshold per year" is checked?
  • Do we need to show only once "Amount and currency" when checkbox "Threshold per year" is empty?
    If so, Please update taxonomy as checkbox "Threshold per year" is missing there.

github_question

@hricolor hricolor reopened this Sep 20, 2022
@hricolor
Copy link
Collaborator

Hi @JelenaCaik, many thanks for your comment again.
We are reviewing it and will provide you with an answer as soon as possible.
Best Regards,
The ESPD team.

@acolomer
Copy link
Contributor

Good morning,
Thank you very much for your comment.
As shown in the following image, an intermediate requirement that represents the selection of "threshold per year" is necessary to make it clearer:
image

  • A new requirement has been added to the data structures that allows selecting whether it should apply for each individual year or for all years;
  • In casi it is for individual yeara, the question_subgroup that has 1..n and is marked in yellow, should be replicated as many times as years required;
  • Since there is no other equal data structure, a new UUID has been generated to cover this data structure.
    Those changes will be applied within the branch criterion_evolution (to add link) and will end up being implemented in future releases.
    Best regards,
    The ESPD team

@acolomer
Copy link
Contributor

acolomer commented Oct 7, 2022

Good morning,
The changes detailed in the previous comment have been applied in branch criterion_evolution and will be implemented in a future ESPD release.
Best regards,
The ESPD Team

@acolomer acolomer closed this as completed Oct 7, 2022
hricolor added a commit that referenced this issue Nov 18, 2022
This change is the implementation of issue #340.
@JelenaCaik
Copy link

JelenaCaik commented Jan 23, 2023

Hello,
I would like to re-open this issue as based on v3.1.0 we can not implement in the same logic, as it is presented in ESPD EDM Technical Handbook mockups.

29_criterion

Based on ESPD-criterion v3.1.0 we need/can to repeat Requirement group N times, and this is not the aim based on mockups:
Buyer (1):
General_Yearly Turnovers_CA mock-up_ common_threshold

Buyer (2):
General_Yearly_Turnovers_CA mock-up_ commonThreshold

EO:
General_Specific_Yearly_Turnovers_ EO_mock-up

  1. There is a need to change Cardinality for min Requirement group (line 11) - it should be 1.
  2. It should be added ONTRUE and ONFALSE blocks/ groups based on Threshold per year Value:
  • ONFALSE, then show Minimum requirement - Cardinality -1,
  • ONTRUE, then show Minim requirement Cardinality - 1..n

@acolomer acolomer reopened this Jan 24, 2023
delgajc added a commit that referenced this issue Jan 27, 2023
delgajc added a commit that referenced this issue Jan 27, 2023
@delgajc
Copy link
Contributor

delgajc commented Jan 27, 2023

Good afternoon,
cardinalities have been fixed as requested. The corrected version of the criterion excel file is available here and they will be included in the next patch-release.

Kind Regards,
The ESPD Team.

@delgajc delgajc closed this as completed Jan 27, 2023
pascalinelaur added a commit that referenced this issue Aug 14, 2023
Fix #340 TEDSPD-508, Fix # 374 TEDSPD-512, Fix TEDSPD-377
ON* instruction added
C24 missing cardinality updated
Renaming 2 worksheets for turnover
pascalinelaur added a commit that referenced this issue Aug 16, 2023
Fix issue #340 TEDSPD-508
removing ON*
changing RQ "minimum amount" cardinality to "1..n"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants