Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update libsql library #133

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

haaawk
Copy link
Contributor

@haaawk haaawk commented Aug 21, 2024

Update libsql library to tursodatabase/libsql@5d25018

Signed-off-by: Piotr Jastrzebski <piotr@chiselstrike.com>
@haaawk
Copy link
Contributor Author

haaawk commented Aug 21, 2024

Trying to run tests but yarn install does not seem to work any more:

╰──> yarn install
yarn install v1.22.19
error Workspaces can only be enabled in private projects.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

@ospfranco
Copy link
Contributor

Seems unlikely, are you sure you are running yarn install in the correct folder? Nothing changed since your PR a couple of days ago.

@ospfranco
Copy link
Contributor

OSP 000216

Checked out the PR, yarn install works on root and Example.

@haaawk
Copy link
Contributor Author

haaawk commented Aug 21, 2024

I tried both in repo root and in example dir. Both fail with this error

@haaawk
Copy link
Contributor Author

haaawk commented Aug 21, 2024

Ok I figured it out. It was wrong version of node.

@ospfranco ospfranco merged commit 2b44bd7 into OP-Engineering:main Aug 21, 2024
6 checks passed
@ospfranco
Copy link
Contributor

ospfranco commented Aug 21, 2024

Cool, I assume the tests are running, I will just go ahead and merge it. Will be released soon.

@haaawk
Copy link
Contributor Author

haaawk commented Aug 21, 2024

image

@haaawk
Copy link
Contributor Author

haaawk commented Aug 21, 2024

image

@haaawk
Copy link
Contributor Author

haaawk commented Aug 21, 2024

Thanks @ospfranco

@Volland
Copy link
Contributor

Volland commented Aug 23, 2024

@ospfranco could we get a release version ?

@ospfranco
Copy link
Contributor

already released in the latest version

@ospfranco
Copy link
Contributor

7.3.0 is already out. You can just hover on vscode on the dependency number and it will show you the latest package version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants