Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #608

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #608

wants to merge 1 commit into from

Conversation

I8dNLo
Copy link

@I8dNLo I8dNLo commented Jun 25, 2024

get_treansforms_for_pretrained can not be imported from oml.registry, but can be imported from oml.registry.transforms.

For maxi

  • I've checked contribution guide.

get_treansforms_for_pretrained can not be imported from oml.registry, but can be imported from oml.registry.transforms.

For maxi
@AlekseySh
Copy link
Contributor

Hi, @I8dNLo and thank you for using OML!

There is a shortcut for the import in __init__: https://github.com/OML-Team/open-metric-learning/blob/main/oml/registry/__init__.py#L9.
So, it should work.

We also run code examples in CI system.

What type of error did you get?

@AlekseySh AlekseySh self-assigned this Jun 25, 2024
@I8dNLo
Copy link
Author

I8dNLo commented Jun 25, 2024

Yap, it should work. But it does not :0
I just manually tried your installation guidelines. Also [nlp] version does not install too.
But if someone would import it like I did, all the thing will work

ImportError: cannot import name 'get_transforms_for_pretrained' from 'oml.registry'

@AlekseySh
Copy link
Contributor

@I8dNLo it's super weird. If you open an example in colab it will also work...

PS. The reason why I don't want to instantly accept the changes is because I try to decrease the width of the two-column code examples in Readme so we could see both (at least partially).

@AlekseySh
Copy link
Contributor

@DaloroAT what do u think? why it may happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants