Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from all-contributors:master #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Sep 12, 2024

  1. fix: only comment about no contributions after checking all contribut…

    …ors (#489)
    
    **What**: Fixes #468.
    
    <!-- Why are these changes necessary? -->
    **Why**: Currently, the bot comments _"I couldn't determine ..."_ as
    soon as a potential contributor is found to not have any contributions.
    But if there are multiple potential contributors, that comment shouldn't
    happen.
    
    <!-- How were these changes implemented? -->
    **How**: With these changes, the comment is only added after all
    potential contributors are checked for sending a PR.
    
    <!-- Have you done all of these things?  -->
    **Checklist**:
    <!-- add "N/A" to the end of each line that's irrelevant to your changes
    -->
    <!-- to check an item, place an "x" in the box like so: "- [x]
    Documentation" -->
    - [x] Documentation _(n/a for bug fix)_
    - [x] Ready to be merged <!-- In your opinion, is this ready to be
    merged as soon as it's reviewed? -->
    - ~[ ] Added myself to contributors table.~
    JoshuaKGoldberg committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    db6de74 View commit details
    Browse the repository at this point in the history