clusterissuer: add aws-route53-credentials externalsecret #550
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
computate
approved these changes
Oct 1, 2024
tssala23
approved these changes
Oct 1, 2024
|
This is likely in the wrong spot. The http01 challenge doesn't require route53 credentials - the DNS01 challenge does. |
This was missing from the nerc-certificate-clusterissuers bundle so the manually created aws-route53-credentials secret that we created on the nerc-ocp-obs cluster during bootstrapping wasn't being synced with vault. See: nerc-project/operations#750
jtriley
force-pushed
the
clusterissuer-externalsecret-route53
branch
from
7144793
to
ed9eb25
Compare
|
I updated this to move the externalsecret to the |
tssala23
approved these changes
Oct 2, 2024
computate
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missing from the
nerc-certificate-clusterissuersbundle so the manually created aws-route53-credentials secret that we created on the nerc-ocp-obs cluster during bootstrapping wasn't being synced with vault.See: nerc-project/operations#750