Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules for JSON formatting #206

Closed
zimeon opened this issue Oct 9, 2018 · 9 comments
Closed

Rules for JSON formatting #206

zimeon opened this issue Oct 9, 2018 · 9 comments
Assignees
Labels
Editorial Editorial issues (no changes to intent)
Milestone

Comments

@zimeon
Copy link
Contributor

zimeon commented Oct 9, 2018

I see one major inconsistency in our JSON formatting: are there spaces inside [ and ]. ie.

"state": {
    "4d27c8...b53": [ "foo/bar.xml" ],
    "cf83e1...a3e": [ "empty.txt", "empty2.txt" ]
  }

or

"state": {
    "4d27c8...b53": ["foo/bar.xml"],
    "cf83e1...a3e": ["empty.txt", "empty2.txt"]
  }

I note that the Moab examples have two spaces after the : in the state blocks, which should also be changed to one.

@zimeon zimeon added the Editorial Editorial issues (no changes to intent) label Oct 9, 2018
@ahankinson
Copy link
Contributor

I would vote for the second option for formatting, if we were voting.

@awoods
Copy link
Member

awoods commented Oct 9, 2018

No preference here... beyond a vote for consistency.

@neilsjefferies
Copy link
Member

Likewise no prefernce...second it is then.

@zimeon
Copy link
Contributor Author

zimeon commented Oct 9, 2018

I have preference for the first form (which I why I used it)... so down to @rosy1280 to tie break

@zimeon zimeon added this to the Alpha milestone Oct 12, 2018
@ahankinson
Copy link
Contributor

ahankinson commented Oct 16, 2018

:tumbleweed:

@rosy1280 , @julianmorley please speak up.

@ahankinson
Copy link
Contributor

Oops, sorry @neilsjefferies

@rosy1280
Copy link
Contributor

i vote for option 1

@julianmorley
Copy link
Contributor

option 1

@ahankinson
Copy link
Contributor

Assigning to myself for PR

ahankinson added a commit that referenced this issue Oct 17, 2018
Fixes #206

Also removed tabs from the Moab examples
zimeon pushed a commit that referenced this issue Oct 17, 2018
* Formatting JSON

Fixes #206

Also removed tabs from the Moab examples

* Fixed missing spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editorial Editorial issues (no changes to intent)
Projects
None yet
Development

No branches or pull requests

6 participants