[14.0][MIG] project_purchase_link #1034
Conversation
| widget="statinfo" | ||
| /> | ||
| </button> | ||
| <button |
There was a problem hiding this comment.
I think here is something wrong. There are several buttons with the same "name" attribute, and I think some of the buttons are added twice.
There was a problem hiding this comment.
Please rename this PR to « [14.0][MIG] project_purchase_link »
Functional tests are ok.
About code review:
- Add
attrs="{'invisible': [('my_value', '=', 0)]}"to each buttons. - Never replace existing copyright headers, please revert these changes.
- Never replace module author in manifest, please revert this change.
You have already added your name to the contributor list and its enough. In my opinion, adding your name as a module author would require a massive contribution.
|
Still some things, already written before :
|
Urvisha-OSI
changed the title
|
/ocabot migration project_purchase_link |
|
The migration issue (#721) has been updated to reference the current pull request. |
|
@max3903 @emagdalenaC2i could you review this one or re-activate #773 ? Thank you! |
|
/ocabot rebase |
|
@rafaelbn The rebase process failed, because command |
|
Please @Urvisha-OSI could you rebase and make a empty commit tu unblock runboat? |
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-13.0/project-13.0-project_purchase_link Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_purchase_link/
max3903
force-pushed
the
14.0-mig-project_purchase_link
branch
from
71b4898
to
92be579
Compare
Done |
|
/ocabot migration project_purchase_link |
|
@max3903 The migration issue commenter process could not start, because of exception Command '['git', 'fetch', '--quiet', '--force', '--prune', 'https://github.com/OCA/project', 'refs/heads/:refs/heads/']' returned non-zero exit status 128.. |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@max3903 your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1034-by-max3903-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
max3903
force-pushed
the
14.0-mig-project_purchase_link
branch
from
92be579
to
dc7f8a6
Compare
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 7cc414b. Thanks a lot for contributing to OCA. ❤️ |
No description provided.