[14.0][FIX][l10n_br_nfe] falha no cancelamento de nota fiscal sem retorno #3182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @renatonlima, |
antoniospneto
requested changes
Jul 15, 2024
DiegoParadeda
force-pushed
the
fix/fiscal_doc_cancel_validation
branch
from
830b98e
to
b322417
Compare
|
@DiegoParadeda agora está pronto para revisão? |
Sim @antoniospneto! Tinha esquecido de atualizar aqui |
DiegoParadeda
changed the title
antoniospneto
approved these changes
Aug 23, 2024
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at b8e72bd. Thanks a lot for contributing to OCA. ❤️ |
|
@DiegoParadeda pode portar para as versões superiores ? |
This was referenced Aug 29, 2024
Merged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acredito que o commit f6d0e9e tenha trazido resultados não desejados uma vez que o campo justificativa (no cancelamento da nota fiscal) precisa ter no mínimo 15 caracteres.
Essa propriedade passava despercebida e, com o commit, o erro passou a ocorrer sem nenhum tipo de retorno para o usuário.
Esse PR trava o cancelamento da nota fiscal caso o tamanho mínimo da justificativa não tenha sido atendida: