Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added notes for additional issues #640

Closed
wants to merge 1 commit into from
Closed

Conversation

fehguy
Copy link
Contributor

@fehguy fehguy commented Apr 8, 2016

FOR DISCUSSION ONLY, DON'T MERGE

Addresses:
#214, #469
#169 (move to different parent)
#182 (move to different parent)
#213
#239 (move to different parent)
#208
OAI/Overlay-Specification#34
#577
#555
#541
#508
#581
#588
#132
#146 (move to different parent)
#341


## Allow references between operations inside descriptions. #239

- [ ] Proposal: this is really about _links_ and belongs in the #586 issue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is about links in the documentation, not about links in the payload. I don't see how this relates.


And remove the separate `host`, `basePath`, `schemes`. Because the port will never be the same between http, https, it makes no sense to support multiple ones

Fixes #489, #214
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fehguy Please also consider #641 since it's tightly connected to this change.

@fehguy fehguy mentioned this pull request Apr 11, 2016
@fehguy
Copy link
Contributor Author

fehguy commented Apr 11, 2016

Closing as issues, PRs have been created, taking into account feedback on this.

@fehguy fehguy closed this Apr 11, 2016
@fehguy fehguy deleted the issue-comments branch October 20, 2016 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants