Fix use types #1129
Merged
Fix use types #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Estimated impact to a consuming app, depending on which bundle is imported
|
|
@MichalBryxi, would you like to review? |
NullVoxPopuli
commented
May 3, 2024
| @@ -10,7 +10,7 @@ export interface InternalFunctionResourceConfig<Value = unknown> { | |||
| [INTERNAL]: true; | |||
| } | |||
|
|
|||
| export const CURRENT = Symbol('ember-resources::CURRENT'); | |||
| export const CURRENT = Symbol('ember-resources::CURRENT') as unknown as 'CURRENT'; | |||
There was a problem hiding this comment.
this is the fix: typescript has been annoying with symbols and inferred types lately. :(
|
Question: The test checks that Ember code works. But does that also prove that TS won't report problems? My example code compiled just fine. I was only getting squiggly line under respective TS code. Is that guaranteed because the TS checks on the testing source code would fail? |
yeah, from all of
|
MichalBryxi
approved these changes
May 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1128
Issues:
CURRENTsymbol was exposed, and caused interface matching to fail -- it has been cast to a non-symbol via the same lies @runspired is using in ember-data 😅Unresolved:
useapis