Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra modernization, support both built in types from ember-source, as well as the types from DefinitelyTyped #1097

Merged
merged 32 commits into from
Jan 10, 2024

Conversation

NullVoxPopuli
Copy link
Owner

@NullVoxPopuli NullVoxPopuli commented Jan 10, 2024

Should be non-breaking for consumers.

Diff is bonkers because this change moves from a single (traditional) lockfile to multiple lockfiles to enforce more isolation between workspaces.

@NullVoxPopuli NullVoxPopuli added the enhancement New feature or request label Jan 10, 2024
Copy link

stackblitz bot commented Jan 10, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 10, 2024

Estimated impact to a consuming app, depending on which bundle is imported

js min min + gzip min + brotli
/index.js 14.06 kB 2.23 kB 971 B 807 B

Copy link
Contributor

github-actions bot commented Jan 10, 2024

Copy link

vercel bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ember-resources ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 11:12pm

ugh

Re-roll lockfile

lint:fix
@NullVoxPopuli NullVoxPopuli changed the title Modernization, use simpler babel transform, emit declarations to separate directory Infra modernization, support both built in types from ember-source, as well as the types from DefinitelyTyped Jan 10, 2024
@NullVoxPopuli NullVoxPopuli merged commit 39c6cc4 into main Jan 10, 2024
26 checks passed
@NullVoxPopuli NullVoxPopuli deleted the modernized-build branch January 10, 2024 23:48
@github-actions github-actions bot mentioned this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant