-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rss: Fix timer sync #2569
rss: Fix timer sync #2569
Conversation
I'm gonna try the fix now. |
Same problem. One thing I didn't notice is rutorrent grabs releases at the same time
edit: clarification |
@Antorell On the system I tested it fixed the problem. It is unlikely that nothing has changed, did you clear the browser's cache? Otherwise it would be helpful to know which calls occur on your system by adding some logging
Since there is no push mechanism (such as SSE or WebSocket) to signal the frontend that the feeds have completed loading, it is assumed that downloading and parsing the feeds takes no longer than 45 seconds. After this delay the frontend calls |
The cache is cleared yes. The cache of the browsers I use always cleared anyway as it's set to delete the cache when the browsers close, and edge is set to shutdown/not remain in memory on close.
Maybe we weren't looking at the same issue. The thing that bugged me the most was the triggering of I tried with a 10 sec delay ( Thanks again for making this timeout more obvious. I'll just keep on editing ( |
45 seconds as an upper bound is not that unreasonable since there are some networks that are not that fast. If the greatest expected delay was lower than this, the socket connection timeout (currently at 30s) might also need adjusting. ruTorrent/php/Snoopy.class.inc Line 95 in fba3d61
However, I think, it it would be best to leave it as it is, right now. |
Target set for ruTorrent |
@TrimmingFool Ready to merge into develop when conflicts are resolved. |
eb6aa9a
to
d613857
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate variables need resolved before merging.
init.js
for RSS has 1700 lines of code. Tasks are being performed that do not directly initialize the interface. I will merge this PR since it doesn't contribute to the problem.
Could we possibly make a new class for parsing bbcode to html and transforming it? This would allow us to further develop the RSS feeds feature on ruTorrent. It's very difficult to debug right now and theWebUI object is polluted.
d613857
to
91a713d
Compare
91a713d
to
92fe0db
Compare
@Antorell Does the timer work as intended with this fix?
The timer now indicates when the next
loadRSS
will be called.Fixes #2568