-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSS plugin should use guid for history management #2637
Comments
@de666 Thanks for this! Currently, the I am not sure if only changing Line 301 in 2d67a00
If no one else wants to take this on, I think, I would, eventually. |
@TrimmingFool Version 4.3 will be released in the near future. Would you like to sneak this important change in? |
I think so, that was the same issue I had and I came up to the conclusion that was the reason. |
I looked at my RSS feed closer and only thing I saw changing was the time. You had RSS that links changed, but i think that is not the only possibility. Most RSS feeds dont change the time for torrents, but this one does. Exact same torrent, but |
I have looked this issue and I think change from link to guid will not fix my issue. Currently link, hash and timestamp is checked and if one of them is not the same then torrent is downloaded again. Some feeds have new timestamp in every feed update and torrents that have already been deleted will be downloaded again because time is changed. Even if torrents get identified by guid. Hash should be enough to indentify the content of the torrent and i dont think time or link needs to be checked again because data have not changed. It probably download torrents again and again even if torrent and data is not deleted but that does not show because torrent is already in torrents table and it gets merged into one. This also should not happen just because timestamp or link is different. Most importent thing is the content of the torrent and that is defined by hash. So i tried to think what would be the downside to get ride of link and timestamp from checking torrents history? I could not think of any. Hash should be enough to identify torrents that is already loaded and should not be downloaded again. Am i wrong? |
Please complete the following tasks.
Tell us about your environment
ruTorrent: v4.2.9
Tell us how you installed ruTorrent
using
https://github.com/crazy-max/docker-rtorrent-rutorrent/releases/tag/4.2.9-0.9.8_2-0.13.8_2-r0
Describe the bug
Using rss plugin with feed which sometimes changes final link maintaining the same guid (like Jackett does), history is not managed the correct way because it refers to final download url (link element) instead of guid which (if present and valid) shuold be used as history reference because is unique and it doesn't change.
Steps to reproduce
Expected behavior
rss plgin shuold handle correctly the torrent already loaded.
This bug causes also rssmanager is not working properly because if the torrent has been already loaded, completed and removed from active torrent list, it is loaded again.
Additional context
No response
The text was updated successfully, but these errors were encountered: