Unified Sequence Number(s): McuManager now tracks Sequence Numbers and rotates them for every single command/write/send #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d rotates them for every single command/write/send Previously, only ImageManager was handling sequence numbers, and that too, only for upload. All other issued commands / writes defaulted to sequence number zero. I think a possible cause for issues in the validated / timeout stage was that when issuing commands that were not the upload, we were going back to sequence number zero. And they might've been dropped / confused by the rest of the code. Now they're integrated within McuManager, so they're used for all commands. This required deeper changes into the ImageManager logic, but I think we might've solved a couple of previous issues. Maybe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only ImageManager was handling sequence numbers, and that too, only for upload. All other issued commands / writes defaulted to sequence number zero. I think a possible cause for issues in the validated / timeout stage was that when issuing commands that were not the upload, we were going back to sequence number zero. And they might've been dropped / confused by the rest of the code. Now they're integrated within McuManager, so they're used for all commands. This required deeper changes into the ImageManager logic, but I think we might've solved a couple of previous issues.
Maybe.