Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release cyclic reference after upgradeDidComplete #72

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Release cyclic reference after upgradeDidComplete #72

merged 2 commits into from
Sep 19, 2022

Conversation

RickGroenewegen
Copy link
Contributor

This concerns the following issue:

#69

The cyclic reference is released too fast so upgradeDidComplete will never fire.

@CLAassistant
Copy link

CLAassistant commented Sep 14, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@RickGroenewegen RickGroenewegen mentioned this pull request Sep 14, 2022
Closed
@RickGroenewegen
Copy link
Contributor Author

I think it also might fix these issues:

#71
#52

@Fabbi
Copy link

Fabbi commented Sep 17, 2022

fail on line 262 will need this change, too.

Also it sadly doesn't fix #52

@dinesharjani dinesharjani merged commit 61aa312 into NordicSemiconductor:master Sep 19, 2022
@dinesharjani
Copy link
Contributor

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RickGroenewegen @CLAassistant @Fabbi @dinesharjani