FirmwareUpgradeController API Expansion #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So, if you're a user of the API, you need a way, when you get the SUIT Delegate Callback, to provide the Data. Most API users, we assume, will keep their reference to the Upgrade Manager of their own, as is the case of the Example App. But, if you don't and you might be using the Delegate's API's returned protocol FirmwareUpgradeController, you might need a way to provide your resource there. So if we expanded the Controller's API to support this. I also had the thought of killing this 'Controller' protocol since it's mostly the FirmwareUpgradeManager itself. But, I thought giving us more API flexibility in the future might be a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, if you're a user of the API, you need a way, when you get the SUIT Delegate Callback, to provide the Data. Most API users, we assume, will keep their reference to the Upgrade Manager of their own, as is the case of the Example App. But, if you don't and you might be using the Delegate's API's returned protocol FirmwareUpgradeController, you might need a way to provide your resource there. So if we expanded the Controller's API to support this. I also had the thought of killing this 'Controller' protocol since it's mostly the FirmwareUpgradeManager itself. But, I thought giving us more API flexibility in the future might be a good idea.