Initial Direct XIP Support + Revert of Default Image Slot Value (back to 0) #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to 0) This commit represents the first time we were able to upload Direct XIP without having to stop the debugger, check something, modify something in the code, etc. Now, this doesn't mean that it's finished - I believe it can be made a lot tidier. But it's closer. As for the revert on the Default Image Slot value, if we leave Direct XIP aside, what we want every time is for the image to be in slot 0. That's what our comparison for 'is this already uploaded?' is against. Hence, why the correct value, I think now after going back and forth a couple of times, is zero for how we've been doing things up until now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit represents the first time we were able to upload Direct XIP without having to stop the debugger, check something, modify something in the code, etc. Now, this doesn't mean that it's finished - I believe it can be made a lot tidier. But it's closer.
As for the revert on the Default Image Slot value, if we leave Direct XIP aside, what we want every time is for the image to be in slot 0. That's what our comparison for 'is this already uploaded?' is against. Hence, why the correct value, I think now after going back and forth a couple of times, is zero for how we've been doing things up until now.