Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE operation timeouts increased #87

Merged
merged 1 commit into from
Dec 1, 2022
Merged

BLE operation timeouts increased #87

merged 1 commit into from
Dec 1, 2022

Conversation

philips77
Copy link
Member

This PR increases the timeouts for all BLE operations:

  1. Short timeout, for quick operations was increased from 1 sec to 2.5 seconds.
  2. Medium timeout changed from 2.5 sec to 5 seconds.
  3. Long timeout, mainly used by "erase" operations was increased from 30 to 40 seconds. This change has less to do with BLE performance, but to prevent timeouts when erasing memory of larger devices.

The reason for the change is to support older devices after a packet size has been increased recently. Devices running NCS 2+ can send 2475 bytes per single SMP packet, which on older Android phones takes long time.

This PR fixes #72. Hopefully. Tested on Samsung Folder with Android 6.0.1 and it was enough to make both DFU and FS operations successful.

@philips77 philips77 merged commit cfbebcc into main Dec 1, 2022
@philips77 philips77 deleted the improvement/timeouts branch December 1, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firmware Upgrade "Connection timed out" in 1.4.1 example app
1 participant