Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address division by zero warnings in arima #770

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Address division by zero warnings in arima #770

merged 2 commits into from
Jan 24, 2024

Conversation

jmoralez
Copy link
Member

Addresses two warnings, one when we try to take the log of zero and another one where we divide by zero. Both of these return Inf in R without a warning, so we replicate that behavior.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jmoralez jmoralez merged commit 678364e into main Jan 24, 2024
17 checks passed
@jmoralez jmoralez deleted the arima-warnings branch January 24, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant