Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix search_arima #752

Merged
merged 2 commits into from
Jan 9, 2024
Merged

fix search_arima #752

merged 2 commits into from
Jan 9, 2024

Conversation

jmoralez
Copy link
Member

@jmoralez jmoralez commented Jan 8, 2024

Completes the search_arima function to be the same as forecast's search.arima, except for the parallel support.

Also addresses a deprecation warning from numpy.

Fixes #740

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jmoralez jmoralez marked this pull request as ready for review January 8, 2024 21:13
@jmoralez jmoralez added the fix label Jan 8, 2024
Copy link
Member

@AzulGarza AzulGarza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! LGTM🥳

@jmoralez jmoralez merged commit 99178e4 into main Jan 9, 2024
17 checks passed
@jmoralez jmoralez deleted the fix-search-arima branch January 9, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AutoARIMA] Exogenous features ignored with stepwise selection turned off
2 participants