[Core] Fixed RuntimeWarning Generated by _get_cols (#538)

[taniishkaaa]

Fixes #538

[kvnkho]

Hey @taniishkaaa , on this one, you need to fix it here: https://github.com/Nixtla/statsforecast/blob/main/nbs/src/core/core.ipynb

And then type nbdev in the terminal to make the new .py file. The .py file is created from the .ipynb file. Otherwise, this change will not persist when someone else edits the .ipynb file.

And then you can clean the notebooks using the command ./action_files/clean_nbs and verify that the linters pass using ./action_files/lint

More instructions can be found in CONTRIBUTING here.

[taniishkaaa]

hi @kvnkho im having trouble installing the libraries within the environment.yml file. It produces the following error:
Command 'mamba' not found, did you mean: command 'samba' from deb samba (2:4.15.13+dfsg-0ubuntu1.1) Try: sudo apt install <deb name>
Can you help me resolve this issue?

[kvnkho]

Sorry late reply @taniishkaaa , I think you shouldn't need mamba to install the dependencies. On your fork if you clone the repo, you can navigate to the root of the directory and do:

pip install -e ".[dev]"

If you have pip available. If you use conda, you can run the pip install inside a new environment.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[kvnkho]

@taniishkaaa , I see you already changed the code in the right notebook. We're nearly there.

Just run nbdev_export to generate the .py file from the change to the notebook. Note you need nbdev installed for this.

Also, it looks like his branch now just has merge conflicts due to the changes in master. I think you merged rather than rebased? It might be easiest if you just branched off the new main again and did these changes. I can hop on a call and help you with that if you want.

[kvnkho]

Could you give me access to your fork? https://github.com/taniishkaaa/statsforecast/ . I think I can fix it also.

[taniishkaaa]

I'm comfortable either way. Also, you now have access to the fork.

[kvnkho]

@taniishkaaa , we did it! Just needed to merge the master into your branch and run nbdev_export.

Thanks for the contribution! I'll let the tests pass and then I'll accept this and merge it in.

[taniishkaaa]

@taniishkaaa , we did it! Just needed to merge the master into your branch and run nbdev_export.

Thanks for the contribution! I'll let the tests pass and then I'll accept this and merge it in.

yay! Thanks for all your help. lmk if I can help contribute some more