Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Unnecessary datetime column conversion #558

Merged
merged 7 commits into from
Jul 11, 2023
Merged

[FIX] Unnecessary datetime column conversion #558

merged 7 commits into from
Jul 11, 2023

Conversation

akmalsoliev
Copy link
Contributor

Converted the column to numpy datetime even if it is already in datetime format. Unnecessary conversion.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@akmalsoliev akmalsoliev changed the title [FIX] Did not properly convert datetime column [FIX] Unnecessary datetime column conversion Jun 15, 2023
@akmalsoliev akmalsoliev changed the title [FIX] Unnecessary datetime column conversion [FIX] Unnecessary datetime column conversion [DRAFT] Jun 20, 2023
@akmalsoliev akmalsoliev changed the title [FIX] Unnecessary datetime column conversion [DRAFT] [FIX] Unnecessary datetime column conversion Jun 21, 2023
@akmalsoliev
Copy link
Contributor Author

Env setup error, nothing major.

@AzulGarza AzulGarza self-requested a review July 11, 2023 06:35
Copy link
Member

@AzulGarza AzulGarza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @akmalsoliev! LGTM :)

@AzulGarza AzulGarza merged commit a6eff82 into Nixtla:main Jul 11, 2023
29 of 30 checks passed
@akmalsoliev akmalsoliev deleted the polars_conversion_error branch July 11, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants