-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenJDK: 13.0.2 -> 14.0.1 #83116
OpenJDK: 13.0.2 -> 14.0.1 #83116
Conversation
i686 is going to be a problem, because OpenJDK only supports bootstrapping with the previous or same major version, and our bootstrap version is 12. We will probably need to create an OpenJDK 13 bootstrap tarball for i686. There are scripts to do this, although I haven't tested them. The biggest problem I see is ensuring that the resulting tarball is trustworthy. |
Yeah, we had that exact same problem in the 12 -> 13 PR (#70983), and I've just extended the same approach I took there: keep the expression for 13 around and use it to bootstrap 14. Perhaps not elegant, but since i686 isn't a primary platform targeted by nixpkgs, it doesn't bother me too much to require a bit of extra building from source in that case. I'm going to run my eclipse on top of this build for a couple of days at work this week, and if all goes well I'll remove the 'WIP' from the title here and be ready to merge. |
Seems to have worked fine so far at work this week. I'm removing the WIP and I think it's ready to merge. |
bumped to 14.0.1, which was released today. |
Other than the rebase that is required, LGTM |
@jerith666 ping, please rebase the PR to fix the conflict |
weird, it rebased cleanly with no conflicts from the command line ... |
I just successfully built this on Arch Linux. |
as done in 373236c for all other uses
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)cc @edwtjo @shlevy @NeQuissimus @lopsided98 @xfix @petabyteboy