msi-ec-kmods: init at 0-unstable-2024-09-19 #343038

m1dugh · 2024-09-19T14:38:25Z

Adds driver `msi-ec-kmods`

Adds the driver for (msi embedded controller)[https://github.com/BeardOverflow/msi-ec].

Things done

Built on platform(s)
- x86_64-linux
- aarch64-linux
- x86_64-darwin
- aarch64-darwin
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Tested basic functionality of driver
Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

NotAShelf

There seems to be several issues with this PR.

You will want to format new files with nixfmt-rfc-style. You might have noticed that the formatting PR is failing
Editorconfig check is also failing, see if your editor integrates with it and try to conform to nixpkgs' editorconfig
Please rebase this PR, a rogue PR has managed to sneak in your git history, you might want to drop it.
Adding yourself to maintainers/maintainer-list.nix must be done in a separate commit. You will need to rebase again for this.

m1dugh · 2024-09-19T17:07:09Z

I have fixed most issues, I am not sure to understand the rogue PR part.

NotAShelf · 2024-09-19T17:09:32Z

Sorry, I meant a rogue commit*. Seems to be fixed though, so no worries.

pkgs/os-specific/linux/msi-ec/default.nix

m1dugh · 2024-09-19T17:22:34Z

Should be all good now

pkgs/os-specific/linux/msi-ec/default.nix

NotAShelf

Derivation LGTM. As a last remark, you will want to update the commit message and the PR title to both show msi-ec-kmods: init at 0-unstable-2024-09-19

GetPsyched

Derivation LGTM

NotAShelf · 2024-09-19T18:01:35Z

Result of nixpkgs-review pr 343038 run on x86_64-linux 1

10 packages marked as broken and skipped:

linuxKernel.packages.linux_4_19.msi-ec
linuxKernel.packages.linux_4_19_hardened.msi-ec
linuxKernel.packages.linux_5_10.msi-ec
linuxKernel.packages.linux_5_10_hardened.msi-ec
linuxKernel.packages.linux_5_15.msi-ec
linuxKernel.packages.linux_5_15_hardened.msi-ec
linuxKernel.packages.linux_5_4.msi-ec
linuxKernel.packages.linux_5_4_hardened.msi-ec
linuxKernel.packages.linux_6_1.msi-ec
linuxKernel.packages.linux_6_1_hardened.msi-ec

2 packages failed to build:

linuxKernel.packages.linux_6_11.msi-ec
linuxKernel.packages.linux_latest_libre.msi-ec

8 packages built:

linuxKernel.packages.linux_6_10.msi-ec
linuxKernel.packages.linux_6_6.msi-ec
linuxKernel.packages.linux_hardened.msi-ec (linuxKernel.packages.linux_6_6_hardened.msi-ec)
linuxKernel.packages.linux_libre.msi-ec
linuxKernel.packages.linux_lqx.msi-ec
linuxKernel.packages.linux_xanmod.msi-ec
linuxKernel.packages.linux_xanmod_latest.msi-ec (linuxKernel.packages.linux_xanmod_stable.msi-ec)
linuxKernel.packages.linux_zen.msi-ec

m1dugh · 2024-09-19T18:12:00Z

Should the 2 build failures be fixed before merging or not @NotAShelf ?

NotAShelf · 2024-09-19T18:17:05Z

Yes, the build fails on both mainline Linux and Linux-Libre. Neither of those are packages we can skip.

m1dugh · 2024-09-19T19:47:11Z

Here is the result after fix of nixpkgs-review pr 343038 on x86_64-linux

10 packages marked as broken and skipped:
linuxKernel.packages.linux_4_19.msi-ec linuxKernel.packages.linux_4_19_hardened.msi-ec linuxKernel.packages.linux_5_10.msi-ec linuxKernel.packages.linux_5_10_hardened.msi-ec linuxKernel.packages.linux_5_15.msi-ec linuxKernel.packages.linux_5_15_hardened.msi-ec linuxKernel.packages.linux_5_4.msi-ec linuxKernel.packages.linux_5_4_hardened.msi-ec linuxKernel.packages.linux_6_1.msi-ec linuxKernel.packages.linux_6_1_hardened.msi-ec

10 packages built:
linuxKernel.packages.linux_6_10.msi-ec linuxKernel.packages.linux_6_11.msi-ec linuxKernel.packages.linux_6_6.msi-ec linuxKernel.packages.linux_hardened.msi-ec linuxKernel.packages.linux_latest_libre.msi-ec linuxKernel.packages.linux_libre.msi-ec linuxKernel.packages.linux_lqx.msi-ec linuxKernel.packages.linux_xanmod.msi-ec linuxKernel.packages.linux_xanmod_latest.msi-ec linuxKernel.packages.linux_zen.msi-ec

maintainers/maintainer-list.nix

Bot-wxt1221

LGTM

m1dugh · 2024-09-29T15:48:12Z

Any idea of when it can be merged ?

pkgs/os-specific/linux/msi-ec/patches/Makefile

pkgs/os-specific/linux/msi-ec/default.nix

pkgs/os-specific/linux/msi-ec/patches/Makefile

pkgs/os-specific/linux/msi-ec/default.nix

m1dugh · 2024-10-06T14:33:26Z

@tomodachi94 Should be all good

pkgs/os-specific/linux/msi-ec/default.nix

m1dugh · 2024-10-06T17:45:33Z

@tomodachi94 The requested changes cannot be resolved due to force-push, if it is good for you can you accept the changes ? 😅

tomodachi94

Lgtm, thank you! The initial PR was really good for just your first contribution 🙂

Adds msi-ec-kmods kernel module for msi embedded controllers.

tomodachi94

Something small that I missed in the original review

tomodachi94 · 2024-10-06T19:12:02Z

pkgs/os-specific/linux/msi-ec/default.nix

+  meta = {
+    description = "Kernel modules for MSI Embedded controller";
+    homepage = "https://github.com/BeardOverflow/msi-ec";
+    license = lib.licenses.gpl2;


Suggested change

license = lib.licenses.gpl2;

license = lib.licenses.gpl2Plus;

See https://github.com/BeardOverflow/msi-ec/blob/main/msi-ec.c#L1. `lib.licenses.gpl2' is deprecated.

GetPsyched · 2024-10-06T20:05:13Z

pkgs/os-specific/linux/msi-ec/default.nix

+  lib,
+  fetchFromGitHub,
+  linuxPackages,
+  pkgs,


I could be wrong here, but can we not simply import git instead of pkgs and replace pkgs.git -> git later in the derivation?

github-actions bot added the 8.has: maintainer-list (update) label Sep 19, 2024

NixOSInfra added the 12. first-time contribution label Sep 19, 2024

NotAShelf suggested changes Sep 19, 2024

View reviewed changes

m1dugh force-pushed the add-msi-embedded-controller-driver branch 2 times, most recently from b61fc42 to 99a43f1 Compare September 19, 2024 17:05

GetPsyched suggested changes Sep 19, 2024

View reviewed changes

pkgs/os-specific/linux/msi-ec/default.nix Outdated Show resolved Hide resolved

pkgs/os-specific/linux/msi-ec/default.nix Outdated Show resolved Hide resolved

pkgs/os-specific/linux/msi-ec/default.nix Outdated Show resolved Hide resolved

m1dugh force-pushed the add-msi-embedded-controller-driver branch from 99a43f1 to df60482 Compare September 19, 2024 17:21

NotAShelf reviewed Sep 19, 2024

View reviewed changes

pkgs/os-specific/linux/msi-ec/default.nix Outdated Show resolved Hide resolved

pkgs/os-specific/linux/msi-ec/default.nix Outdated Show resolved Hide resolved

m1dugh force-pushed the add-msi-embedded-controller-driver branch from df60482 to f56c1e7 Compare September 19, 2024 17:27

m1dugh requested review from NotAShelf and GetPsyched September 19, 2024 17:31

NotAShelf reviewed Sep 19, 2024

View reviewed changes

m1dugh changed the title ~~Add msi embedded controller driver~~ msi-ec-kmods: initat 0-unstable-2024-09-19 Sep 19, 2024

m1dugh changed the title ~~msi-ec-kmods: initat 0-unstable-2024-09-19~~ msi-ec-kmods: init at 0-unstable-2024-09-19 Sep 19, 2024

m1dugh force-pushed the add-msi-embedded-controller-driver branch from f56c1e7 to 77e7790 Compare September 19, 2024 17:37

GetPsyched approved these changes Sep 19, 2024

View reviewed changes

NotAShelf approved these changes Sep 19, 2024

View reviewed changes

NotAShelf added the 12.approvals: 2 label Sep 19, 2024

m1dugh force-pushed the add-msi-embedded-controller-driver branch from 77e7790 to 985c9a8 Compare September 19, 2024 18:28

wegank removed the 12.approvals: 2 label Sep 19, 2024

GetPsyched reviewed Sep 20, 2024

View reviewed changes

maintainers/maintainer-list.nix Outdated Show resolved Hide resolved

m1dugh force-pushed the add-msi-embedded-controller-driver branch from 985c9a8 to 516bd90 Compare September 20, 2024 08:30

ofborg bot added the 8.has: package (new) label Sep 20, 2024

ofborg bot added the 10.rebuild-linux: 11-100 label Sep 20, 2024

Bot-wxt1221 approved these changes Sep 23, 2024

View reviewed changes

Bot-wxt1221 added the 12.approvals: 3+ label Sep 23, 2024

wegank added 12.approvals: 2 and removed 12.approvals: 3+ labels Sep 25, 2024

NotAShelf added the needs_merger label Sep 29, 2024

Bot-wxt1221 added 12.approvals: 3+ 12.approvals: 2 and removed 12.approvals: 2 12.approvals: 3+ labels Sep 29, 2024

Bot-wxt1221 requested a review from GetPsyched September 29, 2024 23:04

tomodachi94 requested changes Oct 5, 2024

View reviewed changes

maintainers: Adds m1dugh

245a23b

m1dugh force-pushed the add-msi-embedded-controller-driver branch from 516bd90 to f706ca3 Compare October 6, 2024 14:32

m1dugh force-pushed the add-msi-embedded-controller-driver branch from f706ca3 to 5cda1c9 Compare October 6, 2024 14:35

Tungsten842 suggested changes Oct 6, 2024

View reviewed changes

pkgs/os-specific/linux/msi-ec/default.nix Outdated Show resolved Hide resolved

m1dugh force-pushed the add-msi-embedded-controller-driver branch 2 times, most recently from 6fc5caa to a5fd31b Compare October 6, 2024 17:43

tomodachi94 approved these changes Oct 6, 2024

View reviewed changes

tomodachi94 requested review from Tungsten842, NotAShelf and Bot-wxt1221 October 6, 2024 17:55

NotAShelf approved these changes Oct 6, 2024

View reviewed changes

msi-ec-kmods: init at 0-unstable-2024-09-19

50e1733

Adds msi-ec-kmods kernel module for msi embedded controllers.

m1dugh force-pushed the add-msi-embedded-controller-driver branch from a5fd31b to 50e1733 Compare October 6, 2024 18:39

tomodachi94 requested changes Oct 6, 2024

View reviewed changes

GetPsyched reviewed Oct 6, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

msi-ec-kmods: init at 0-unstable-2024-09-19 #343038

msi-ec-kmods: init at 0-unstable-2024-09-19 #343038

m1dugh commented Sep 19, 2024 •

edited

Loading

NotAShelf left a comment

m1dugh commented Sep 19, 2024

NotAShelf commented Sep 19, 2024

m1dugh commented Sep 19, 2024

NotAShelf left a comment •

edited

Loading

GetPsyched left a comment

NotAShelf commented Sep 19, 2024

m1dugh commented Sep 19, 2024

NotAShelf commented Sep 19, 2024

m1dugh commented Sep 19, 2024

Bot-wxt1221 left a comment

m1dugh commented Sep 29, 2024

m1dugh commented Oct 6, 2024

m1dugh commented Oct 6, 2024

tomodachi94 left a comment •

edited

Loading

tomodachi94 left a comment

tomodachi94 Oct 6, 2024

GetPsyched Oct 6, 2024

	license = lib.licenses.gpl2;
	license = lib.licenses.gpl2Plus;

msi-ec-kmods: init at 0-unstable-2024-09-19 #343038

Are you sure you want to change the base?

msi-ec-kmods: init at 0-unstable-2024-09-19 #343038

Conversation

m1dugh commented Sep 19, 2024 • edited Loading

Adds driver msi-ec-kmods

Things done

NotAShelf left a comment

Choose a reason for hiding this comment

m1dugh commented Sep 19, 2024

NotAShelf commented Sep 19, 2024

m1dugh commented Sep 19, 2024

NotAShelf left a comment • edited Loading

Choose a reason for hiding this comment

GetPsyched left a comment

Choose a reason for hiding this comment

NotAShelf commented Sep 19, 2024

m1dugh commented Sep 19, 2024

NotAShelf commented Sep 19, 2024

m1dugh commented Sep 19, 2024

Bot-wxt1221 left a comment

Choose a reason for hiding this comment

m1dugh commented Sep 29, 2024

m1dugh commented Oct 6, 2024

m1dugh commented Oct 6, 2024

tomodachi94 left a comment • edited Loading

Choose a reason for hiding this comment

tomodachi94 left a comment

Choose a reason for hiding this comment

tomodachi94 Oct 6, 2024

Choose a reason for hiding this comment

GetPsyched Oct 6, 2024

Choose a reason for hiding this comment

m1dugh commented Sep 19, 2024 •

edited

Loading

Adds driver `msi-ec-kmods`

NotAShelf left a comment •

edited

Loading

tomodachi94 left a comment •

edited

Loading